From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C5666A2EDB
	for <public@inbox.dpdk.org>; Mon, 30 Sep 2019 16:20:13 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 32BD41BE82;
	Mon, 30 Sep 2019 16:20:12 +0200 (CEST)
Received: from huawei.com (szxga07-in.huawei.com [45.249.212.35])
 by dpdk.org (Postfix) with ESMTP id C6B941B952
 for <dev@dpdk.org>; Mon, 30 Sep 2019 16:20:10 +0200 (CEST)
Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.58])
 by Forcepoint Email with ESMTP id D32CD66F0FEBE89EB43C
 for <dev@dpdk.org>; Mon, 30 Sep 2019 22:20:09 +0800 (CST)
Received: from [127.0.0.1] (10.177.29.98) by DGGEMS409-HUB.china.huawei.com
 (10.3.19.209) with Microsoft SMTP Server id 14.3.439.0; Mon, 30 Sep 2019
 22:19:59 +0800
To: Ferruh Yigit <ferruh.yigit@intel.com>
CC: <dev@dpdk.org>, <xuanziyang2@huawei.com>, <shahar.belkar@huawei.com>,
 <luoxianjun@huawei.com>, <tanya.brokhman@huawei.com>,
 <zhouguoyang@huawei.com>, <wulike1@huawei.com>
References: <cover.1569421286.git.cloud.wangxiaoyun@huawei.com>
 <8c0aae44-c1b4-c9f9-55bf-e112e67e7e9b@intel.com>
From: "Wangxiaoyun (Cloud, Network Chip Application Development Dept)"
 <cloud.wangxiaoyun@huawei.com>
Message-ID: <941edbc1-0b51-08f1-51db-b15bdeede520@huawei.com>
Date: Mon, 30 Sep 2019 22:19:58 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.1
MIME-Version: 1.0
In-Reply-To: <8c0aae44-c1b4-c9f9-55bf-e112e67e7e9b@intel.com>
X-Originating-IP: [10.177.29.98]
X-CFilter-Loop: Reflected
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 8bit
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v2 00/17] Add advanced features for Huawei
 hinic pmd
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Ferruh,
     Thanks for your comments, I have sent a new patch V3 with new API changes, and add comments
for every patch version, which is show in cover-letter patch, please check it.

Best regards
Xiaoyun Wang

在 2019/9/27 2:51, Ferruh Yigit 写道:
> On 9/25/2019 3:30 PM, Xiaoyun wang wrote:
>> This patch set adds advanced features for Huawei hinic pmd,
>> such as VLAN filter and VLAN offload, SR-IOV, FW version get,
>> set link down and up, Flow director for LACP, VRRP, BGP and so on.
>>
>> Xiaoyun wang (17):
>>    net/hinic/base: add mbox command channel for SRIOV
>>    net/hinic/base: add HW interfaces for SRIOV
>>    net/hinic: add VF PMD operation interfaces
>>    net/hinic: add VLAN filter and offload
>>    net/hinic: add allmulticast mode and MTU set
>>    net/hinic: add unicast and multicast MAC set
>>    net/hinic: add fdir config interface
>>    net/hinic: add fdir validate flow operations
>>    net/hinic: create and destroy ntuple filter
>>    net/hinic: create and destroy fdir filter
>>    net/hinic: flush fdir filter
>>    net/hinic: set link down and up
>>    net/hinic: support inner L3 checksum offload
>>    net/hinic: support LRO offload
>>    net/hinic: add hinic PMD doc files
>>    net/hinic/base: optimize aeq interfaces
>>    net/hinic: optimize tx&rx performance
> Hi Xiaoyun,
>
> Overall patchset lgtm, only there are a few minor comments, also can you please
> send a new version on top of latest next-net because of the ethdev API updates?
>
> Thanks,
> ferruh
>