From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44443A0C55; Wed, 13 Oct 2021 16:21:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F5B3410DA; Wed, 13 Oct 2021 16:21:01 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id BC3AD40E64 for ; Wed, 13 Oct 2021 16:20:59 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 01C4F7F514; Wed, 13 Oct 2021 17:20:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 01C4F7F514 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1634134859; bh=bhGO68TSp1tzDo4MacKnnAoYOLXTUzRQYUa7LrtUZiQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=BqZm20ZU0/4ZnWYMAUvR5pIzaVw1cSyBYmjwLmvQTOckdzNDg19pzXyUTWCg03DV2 yGLPj3+lBurYFwGEaX+19j1wJHvGTTGEurA/ewWZPMSUrcWxW1Yd5Nb+f6NRS44Zwf vGX6MrwGhFMvSLd5jNITq+Y0iIO3wgNjBWzUnWzY= To: Konstantin Ananyev , dev@dpdk.org Cc: xiaoyun.li@intel.com, anoobj@marvell.com, jerinj@marvell.com, ndabilpuram@marvell.com, adwivedi@marvell.com, shepard.siegel@atomicrules.com, ed.czeck@atomicrules.com, john.miller@atomicrules.com, irusskikh@marvell.com, ajit.khaparde@broadcom.com, somnath.kotur@broadcom.com, rahul.lakkireddy@chelsio.com, hemant.agrawal@nxp.com, sachin.saxena@oss.nxp.com, haiyue.wang@intel.com, johndale@cisco.com, hyonkim@cisco.com, qi.z.zhang@intel.com, xiao.w.wang@intel.com, humin29@huawei.com, yisen.zhuang@huawei.com, oulijun@huawei.com, beilei.xing@intel.com, jingjing.wu@intel.com, qiming.yang@intel.com, matan@nvidia.com, viacheslavo@nvidia.com, sthemmin@microsoft.com, longli@microsoft.com, heinrich.kuhn@corigine.com, kirankumark@marvell.com, mczekaj@marvell.com, jiawenwu@trustnetic.com, jianwang@trustnetic.com, maxime.coquelin@redhat.com, chenbo.xia@intel.com, thomas@monjalon.net, ferruh.yigit@intel.com, mdr@ashroe.eu, jay.jayatheerthan@intel.com References: <0211007112750.25526-1-konstantin.ananyev@intel.com> <20211013133704.31296-1-konstantin.ananyev@intel.com> <20211013133704.31296-2-konstantin.ananyev@intel.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <9421cc81-04eb-da22-6714-184096b06678@oktetlabs.ru> Date: Wed, 13 Oct 2021 17:20:58 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20211013133704.31296-2-konstantin.ananyev@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 1/6] ethdev: allocate max space for internal queue array X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/13/21 4:36 PM, Konstantin Ananyev wrote: > At queue configure stage always allocate space for maximum possible > number (RTE_MAX_QUEUES_PER_PORT) of queue pointers. > That will allow 'fast' inline functions (eth_rx_burst, etc.) to refer > pointer to internal queue data without extra checking of current number > of configured queues. > That would help in future to hide rte_eth_dev and related structures. > It means that from now on, each ethdev port will always consume: > ((2*sizeof(uintptr_t))* RTE_MAX_QUEUES_PER_PORT) > bytes of memory for its queue pointers. > With RTE_MAX_QUEUES_PER_PORT==1024 (default value) it is 16KB per port. > > Signed-off-by: Konstantin Ananyev Reviewed-by: Andrew Rybchenko