From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 9D1E42BDF for ; Tue, 25 Oct 2016 23:09:01 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id c78so187000069wme.0 for ; Tue, 25 Oct 2016 14:09:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=e0MG3q2QBHjugcRqW2bRHrezZnbdVEuga9IkcrXgH1U=; b=qEwFJ1t19e4iQpW8lWL0mKtP+b42z/LhSmknXLUZEwNpLJAAXbWUb5704ZAiAkvMLr CWVI7a0BkjZR3Z0+cswsvwgLsfF88iUcjv7HSoKDP1mkIGCUlanV/96t3LnANI+zPLvp S11J5kgP9EdX8GmSkfeac4dI77BmrqivtblOqzDenpgw3hP6uJxxkDq2rEZmnmotHSfQ HraYZ1dPjUshoqo1M9hbPOQfW6VZloPT4uTWnRjLiDqarit6IBSeBok0zScVhK7ILr75 yyjRdndRyYVpfGYDImC3KBt2kBsJrBuE7Baex5zlLo4a9rsSZhYiCB3rZvRd/1O2emXq +R9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=e0MG3q2QBHjugcRqW2bRHrezZnbdVEuga9IkcrXgH1U=; b=az8yvbBqanft64UqblyldkjHKhKrYUyBjJnm7UyKh9amIlmFnqnlLYDvLDB4XsrWeF PlJjsRhg7X9F8HhWxjP+OvnoEbB+tZBzCYUS7tKlR27E4WI4X57Unz6CakJzRulMMkCf ddn/kni64s+sig6JaEKsbCW4VVzYjAoqxMJjat4yxMOTgjOgfBr36SW1XyzlMSAoHmLo D1rV/NqOWK748Ajr9L6a4WkBfb/m3yOFVfTBjqNoNFX/VdOWOMnPu4a7BcXl/8cJLc/J xEiwE7u7KTydFeV9y95+MDug7wkKKFt0s9yMTIc4znJcCGWPX03v+G7F2Mf9gywpp+Ga BGkA== X-Gm-Message-State: ABUngvcImlUwi7Oi20sB0bpv2RhZI01FlPNtizkm73qn0BRjP7on8tQUcpXcXoV1fRcqY1uG X-Received: by 10.194.126.36 with SMTP id mv4mr18678088wjb.221.1477429741343; Tue, 25 Oct 2016 14:09:01 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id 18sm5711188wmr.5.2016.10.25.14.09.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Oct 2016 14:09:00 -0700 (PDT) From: Thomas Monjalon To: Wenzhuo Lu Date: Tue, 25 Oct 2016 23:08:59 +0200 Message-ID: <9425531.GtZQfLiE8F@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1476839535-1220-1-git-send-email-wenzhuo.lu@intel.com> References: <1476067628-30842-1-git-send-email-wenzhuo.lu@intel.com> <1476839535-1220-1-git-send-email-wenzhuo.lu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix PF/VF check of flow director X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Oct 2016 21:09:01 -0000 2016-10-19 09:12, Wenzhuo Lu: > Parameters pf & vf are added into most of flow director > filter CLIs. > But mac-valn and tunnel filters don't have these parameters, > the parameters should not be checked for mac-vlan and tunnel > filters. > > Fixes: e6a68c013353 ("app/testpmd: extend commands for flow director in VF") > > Signed-off-by: Wenzhuo Lu > Acked-by: Pablo de Lara This bug was reported and fixed by Frederico Cadete: http://dpdk.org/patch/15264 We have waited long to have a review saying it requires an optional parameter in the command line. And finally you re-post a fixed version of the same approach without any comment to the original thread or a reference here. Please be more careful with occasional contributors. Applied with Reported-by: Frederico Cadete