From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BEB1A04B5; Mon, 11 Jan 2021 20:07:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BCF48140D59; Mon, 11 Jan 2021 20:07:57 +0100 (CET) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by mails.dpdk.org (Postfix) with ESMTP id B0B7C140D58 for ; Mon, 11 Jan 2021 20:07:56 +0100 (CET) Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 10BIYTln126406; Mon, 11 Jan 2021 14:07:55 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=FA2yRsCrBDJKFR9VDbdOVWM5QGeO0U/XO1Jrvm3OkJQ=; b=YFknSwEkAsDlyU3u6Xl8ApnKzXuHhwe3y27s9XqNKUVfcKJCSO60RlqJOpLUDGdpd7p2 KKo3wy5sN/AqMYdBkLCae/pCYLzsaP6EFStXFHIdpHwrf6eR3tcy16Sw3mMWy20Q1Nmh 6VhKvqxjj3yZhREMLlIMxrvKQtOqCbB31egdxJceJ3MyjGEfiqWMHFAoxJjCaQeuqD40 7cj3qw7kPevAbd4ioZnWnm06LKjyRbnYfBgV/uOT4HPqjThHwcgHUWlXyDTzAgfKdJnd CHizC1gBI3wCA2XZ+FfBg/+J7oQ/HN6EYa6IjZlAeLNWrGyJvpXOUPc+YLyZ7rqA+mNQ fw== Received: from ppma04wdc.us.ibm.com (1a.90.2fa9.ip4.static.sl-reverse.com [169.47.144.26]) by mx0a-001b2d01.pphosted.com with ESMTP id 360t0gd9t1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Jan 2021 14:07:55 -0500 Received: from pps.filterd (ppma04wdc.us.ibm.com [127.0.0.1]) by ppma04wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 10BJ7QcN027983; Mon, 11 Jan 2021 19:07:54 GMT Received: from b03cxnp07028.gho.boulder.ibm.com (b03cxnp07028.gho.boulder.ibm.com [9.17.130.15]) by ppma04wdc.us.ibm.com with ESMTP id 35y448rrex-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 11 Jan 2021 19:07:54 +0000 Received: from b03ledav006.gho.boulder.ibm.com (b03ledav006.gho.boulder.ibm.com [9.17.130.237]) by b03cxnp07028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 10BJ7rKq24707362 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 11 Jan 2021 19:07:53 GMT Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 4864AC6065; Mon, 11 Jan 2021 19:07:53 +0000 (GMT) Received: from b03ledav006.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0AA58C605A; Mon, 11 Jan 2021 19:07:52 +0000 (GMT) Received: from Davids-MBP.randomparity.org (unknown [9.163.92.50]) by b03ledav006.gho.boulder.ibm.com (Postfix) with ESMTP; Mon, 11 Jan 2021 19:07:52 +0000 (GMT) To: Thomas Monjalon , Ophir Munk Cc: "dev@dpdk.org" , Ori Kam References: <20201216164931.1517-2-ophirmu@nvidia.com> <4985833.vo0Fgz2hKg@thomas> <4006782.2bIctDIqnZ@thomas> From: David Christensen Message-ID: <942d9edc-60e5-640c-9050-8bf76de5e3a5@linux.vnet.ibm.com> Date: Mon, 11 Jan 2021 11:07:52 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <4006782.2bIctDIqnZ@thomas> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2021-01-11_29:2021-01-11, 2021-01-11 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 mlxlogscore=999 clxscore=1011 phishscore=0 impostorscore=0 malwarescore=0 adultscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2101110103 Subject: Re: [dpdk-dev] [PATCH v2 5/6] app/regex: support performance measurements per QP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >>> -----Original Message----- >>> From: Thomas Monjalon >>> Sent: Friday, January 8, 2021 11:09 AM >>> To: Ophir Munk >>> Cc: dev@dpdk.org; Ori Kam >>> Subject: Re: [dpdk-dev] [PATCH v2 5/6] app/regex: support performance >>> measurements per QP >>> >>> 20/12/2020 11:41, Ophir Munk: >>>> Up to this commit measuring the parsing elapsed time and Giga bits per >>>> second performance was done on the aggregation of all QPs (per core). >>>> This commit separates the time measurements per individual QP. >>>> >>>> Signed-off-by: Ophir Munk >>>> --- >>>> --- a/app/test-regex/main.c >>>> +++ b/app/test-regex/main.c >>>> + for (qp_id = 0; qp_id < nb_qps; qp_id++) { >>>> + time = ((double)qp->end - qp->start) / CLOCKS_PER_SEC; >>> >>> This line triggers an error with PPC compiler: >>> error: ‘qp’ may be used uninitialized in this function [-Werror=maybe- >>> uninitialized] >>> time = ((double)qp->end - qp->start) / CLOCKS_PER_SEC; >>> >> Thanks for reporting. >> I sent v3 with a fix. >> Could I have known this error in advance? Is there a CI report? > > No I think there is no CI report for PPC. > Actually the PPC support in DPDK is not clear. IBM is still supporting DPDK on PPC, though we don't have a proper CI infrastructure in place. PPC support is available from Travis but was unreliable when we last attempted to enable it. I'll take Thomas' hint the hint and revisit the issue in 2021. Dave FYI, v2 of the patch built successfully on my PPC test system with gcc 8.3.1. There's a compiler difference between my RH8 environment and the cross-build environment Thomas references.