From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 11305F94 for ; Thu, 3 Nov 2016 21:41:36 +0100 (CET) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 828C14E33D; Thu, 3 Nov 2016 20:41:35 +0000 (UTC) Received: from [10.36.6.90] (vpn1-6-90.ams2.redhat.com [10.36.6.90]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uA3KfWfY007223 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 3 Nov 2016 16:41:34 -0400 To: Yuanhan Liu , dev@dpdk.org References: <1478189400-14606-1-git-send-email-yuanhan.liu@linux.intel.com> <1478189400-14606-3-git-send-email-yuanhan.liu@linux.intel.com> From: Maxime Coquelin Message-ID: <942f5b4e-56ba-a374-7704-169549df5565@redhat.com> Date: Thu, 3 Nov 2016 21:41:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1478189400-14606-3-git-send-email-yuanhan.liu@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 03 Nov 2016 20:41:35 +0000 (UTC) Cc: Ilya Maximets Subject: Re: [dpdk-dev] [PATCH 2/8] net/virtio: simplify queue memzone name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Nov 2016 20:41:36 -0000 On 11/03/2016 05:09 PM, Yuanhan Liu wrote: > Instead of setting up a queue memzone name like "port0_rxq0", "port0_txq0", > it could be simplified a bit to something like "port0_vq0", "port0_vq1" ... > > Meanwhile, the code is also simplified a bit. > > Signed-off-by: Yuanhan Liu > --- > drivers/net/virtio/virtio_ethdev.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c > index 5815875..d082df5 100644 > --- a/drivers/net/virtio/virtio_ethdev.c > +++ b/drivers/net/virtio/virtio_ethdev.c > @@ -312,7 +312,6 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev, > struct virtnet_tx *txvq = NULL; > struct virtnet_ctl *cvq = NULL; > struct virtqueue *vq; > - const char *queue_names[] = {"rvq", "txq", "cvq"}; > size_t sz_vq, sz_q = 0, sz_hdr_mz = 0; > void *sw_ring = NULL; > int ret; > @@ -335,8 +334,8 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev, > return -EINVAL; > } > > - snprintf(vq_name, sizeof(vq_name), "port%d_%s%d", > - dev->data->port_id, queue_names[queue_type], queue_idx); > + snprintf(vq_name, sizeof(vq_name), "port%d_vq%d", > + dev->data->port_id, vtpci_queue_idx); > > sz_vq = RTE_ALIGN_CEIL(sizeof(*vq) + > vq_size * sizeof(struct vq_desc_extra), > @@ -398,9 +397,8 @@ int virtio_dev_queue_setup(struct rte_eth_dev *dev, > (uint64_t)(uintptr_t)mz->addr); > > if (sz_hdr_mz) { > - snprintf(vq_hdr_name, sizeof(vq_hdr_name), "port%d_%s%d_hdr", > - dev->data->port_id, queue_names[queue_type], > - queue_idx); > + snprintf(vq_hdr_name, sizeof(vq_hdr_name), "port%d_vq%d_hdr", > + dev->data->port_id, vtpci_queue_idx); > hdr_mz = rte_memzone_reserve_aligned(vq_hdr_name, sz_hdr_mz, > socket_id, 0, > RTE_CACHE_LINE_SIZE); > Sounds reasonable: Reviewed-by: Maxime Coquelin Thanks, Maxime