From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id A50CF2BA5 for ; Mon, 2 Jan 2017 16:24:14 +0100 (CET) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga102.jf.intel.com with ESMTP; 02 Jan 2017 07:24:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,432,1477983600"; d="scan'208";a="804321986" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by FMSMGA003.fm.intel.com with ESMTP; 02 Jan 2017 07:24:10 -0800 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 2 Jan 2017 07:24:10 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 2 Jan 2017 07:24:09 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.177]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.204]) with mapi id 14.03.0248.002; Mon, 2 Jan 2017 23:24:06 +0800 From: "Xing, Beilei" To: "Zhao1, Wei" , "dev@dpdk.org" CC: "Zhao1, Wei" , "Lu, Wenzhuo" Thread-Topic: [dpdk-dev] [PATCH v2 15/18] net/ixgbe: parse flow director filter Thread-Index: AQHSYnL2uvzhCN+TR0+Gmd9ewqnYjaElUmww Date: Mon, 2 Jan 2017 15:24:05 +0000 Message-ID: <94479800C636CB44BD422CB454846E013158CF29@SHSMSX101.ccr.corp.intel.com> References: <1483084390-53159-1-git-send-email-wei.zhao1@intel.com> <1483084390-53159-16-git-send-email-wei.zhao1@intel.com> In-Reply-To: <1483084390-53159-16-git-send-email-wei.zhao1@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNGQxYjUxYzgtZTg4ZS00ZmI4LWFmMzYtMWIwMjRhNDliMjY4IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImhTTkRqRnVPbkNcLzE4MzZpN2VTVzJ1SjJFM1Z3dThCenlnNjhBWSt2OTRRPSJ9 x-ctpclassification: CTP_IC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 15/18] net/ixgbe: parse flow director filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Jan 2017 15:24:15 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Wei Zhao > Sent: Friday, December 30, 2016 3:53 PM > To: dev@dpdk.org > Cc: Zhao1, Wei ; Lu, Wenzhuo > Subject: [dpdk-dev] [PATCH v2 15/18] net/ixgbe: parse flow director filte= r >=20 > check if the rule is a flow director rule, and get the flow director info= . >=20 > Signed-off-by: Wei Zhao > Signed-off-by: Wenzhuo Lu >=20 > --- >=20 > v2:add new error set function > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 1467 > +++++++++++++++++++++++++++++++++----- > drivers/net/ixgbe/ixgbe_ethdev.h | 16 + > drivers/net/ixgbe/ixgbe_fdir.c | 247 ++++--- > lib/librte_ether/rte_flow.h | 23 + > 4 files changed, 1495 insertions(+), 258 deletions(-) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index 0a5ac4f..c98aa0d 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -438,6 +438,31 @@ ixgbe_validate_l2_tn_filter(struct rte_eth_dev *dev, > struct rte_eth_l2_tunnel_conf *rule, > struct rte_flow_error *error); > static int > +ixgbe_validate_fdir_filter(struct rte_eth_dev *dev, > + const struct rte_flow_attr *attr, > + const struct rte_flow_item pattern[], > + const struct rte_flow_action actions[], > + struct ixgbe_fdir_rule *rule, > + struct rte_flow_error *error); > +static int > +ixgbe_parse_fdir_filter_normal(const struct rte_flow_attr *attr, > + const struct rte_flow_item pattern[], > + const struct rte_flow_action actions[], > + struct ixgbe_fdir_rule *rule, > + struct rte_flow_error *error); > +static int > +ixgbe_parse_fdir_filter_tunnel(const struct rte_flow_attr *attr, > + const struct rte_flow_item pattern[], > + const struct rte_flow_action actions[], > + struct ixgbe_fdir_rule *rule, > + struct rte_flow_error *error); > +static int > +ixgbe_parse_fdir_filter(const struct rte_flow_attr *attr, > + const struct rte_flow_item pattern[], > + const struct rte_flow_action actions[], > + struct ixgbe_fdir_rule *rule, > + struct rte_flow_error *error); > +static int > ixgbe_flow_validate(__rte_unused struct rte_eth_dev *dev, > const struct rte_flow_attr *attr, > const struct rte_flow_item pattern[], > @@ -1475,6 +1500,8 @@ static int ixgbe_fdir_filter_init(struct rte_eth_de= v > *eth_dev) > "Failed to allocate memory for fdir hash map!"); > return -ENOMEM; > } > + fdir_info->mask_added =3D FALSE; > + > return 0; > } >=20 > @@ -8951,117 +8978,22 @@ ixgbe_parse_syn_filter(const struct > rte_flow_attr *attr, > return 0; > } >=20 > -/** > - * Parse the rule to see if it is a L2 tunnel rule. > - * And get the L2 tunnel filter info BTW. > - * Only support E-tag now. > - */ > +/* Parse to get the attr and action info of flow director rule. */ > static int > -cons_parse_l2_tn_filter(const struct rte_flow_attr *attr, > - const struct rte_flow_item pattern[], > - const struct rte_flow_action actions[], > - struct rte_eth_l2_tunnel_conf *filter, > - struct rte_flow_error *error) Why do u remove functions added in patch 14/18? If the functions don't be n= eeded, how about changing patch 14/18?