From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id EA353CF80 for ; Thu, 9 Mar 2017 07:11:44 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Mar 2017 22:11:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,267,1486454400"; d="scan'208";a="73375731" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 08 Mar 2017 22:11:43 -0800 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 8 Mar 2017 22:11:43 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 8 Mar 2017 22:11:42 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.177]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.204]) with mapi id 14.03.0248.002; Thu, 9 Mar 2017 14:11:39 +0800 From: "Xing, Beilei" To: "Yigit, Ferruh" , "Wu, Jingjing" CC: "Zhang, Helin" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 4/4] net/i40e: refine consistent tunnel filter Thread-Index: AQHSlAFSHRWQbqZNLkuyyIX4bdgSp6GKmVGAgAF14DA= Date: Thu, 9 Mar 2017 06:11:38 +0000 Message-ID: <94479800C636CB44BD422CB454846E01315A7D51@SHSMSX101.ccr.corp.intel.com> References: <1488533497-27682-1-git-send-email-beilei.xing@intel.com> <1488533497-27682-5-git-send-email-beilei.xing@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 4/4] net/i40e: refine consistent tunnel filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 06:11:45 -0000 > -----Original Message----- > From: Yigit, Ferruh > Sent: Wednesday, March 8, 2017 11:51 PM > To: Xing, Beilei ; Wu, Jingjing > Cc: Zhang, Helin ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 4/4] net/i40e: refine consistent tunnel fi= lter >=20 > On 3/3/2017 9:31 AM, Beilei Xing wrote: > > Add i40e_tunnel_type enumeration type to refine consistent tunnel > > filter, it will be esay to add new tunnel type for >=20 > s/esay/easy >=20 > > i40e. > > > > Signed-off-by: Beilei Xing >=20 > <...> >=20 > > /** > > + * Tunnel type. > > + */ > > +enum i40e_tunnel_type { > > + I40E_TUNNEL_TYPE_NONE =3D 0, > > + I40E_TUNNEL_TYPE_VXLAN, > > + I40E_TUNNEL_TYPE_GENEVE, > > + I40E_TUNNEL_TYPE_TEREDO, > > + I40E_TUNNEL_TYPE_NVGRE, > > + I40E_TUNNEL_TYPE_IP_IN_GRE, > > + I40E_L2_TUNNEL_TYPE_E_TAG, > > + I40E_TUNNEL_TYPE_MAX, > > +}; >=20 > Same question here, there is already "rte_eth_tunnel_type", why driver is > duplicating the structure? >=20 Same with " struct i40e_tunnel_filter_conf ", to avoid ABI change, we creat= e it in PMD to add new tunnel type easily, like MPLS. > <...>