From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 1C33D2986 for ; Wed, 17 May 2017 04:22:44 +0200 (CEST) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP; 16 May 2017 19:22:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.38,352,1491289200"; d="scan'208";a="1170138003" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 16 May 2017 19:22:38 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 16 May 2017 19:22:38 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 16 May 2017 19:22:38 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.193]) by shsmsx102.ccr.corp.intel.com ([169.254.2.246]) with mapi id 14.03.0319.002; Wed, 17 May 2017 10:22:35 +0800 From: "Xing, Beilei" To: Michael Lilja , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] net/i40e: Improved FDIR programming times Thread-Index: AQHSzpALfeTWJwOxXkqshBhCBFbBnqH3yOsg Date: Wed, 17 May 2017 02:22:34 +0000 Message-ID: <94479800C636CB44BD422CB454846E0131FAF09F@SHSMSX101.ccr.corp.intel.com> References: <20170516220132.3813-1-ml@napatech.com> In-Reply-To: <20170516220132.3813-1-ml@napatech.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjViZjE2YmUtMmQyNS00YzIzLWJiYzYtMDRmZGVmN2YxYWY2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkJIMEM3NVlwSjZpYjN1emIreXJ3a1BxUkFrdGg1T3grQ0pBN1FtckFSNnc9In0= x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 10.0.102.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: Improved FDIR programming times X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 May 2017 02:22:45 -0000 Hi, Seems my comments in v2 are not addressed, add the comments here again. > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Michael Lilja > Sent: Wednesday, May 17, 2017 6:02 AM > To: dev@dpdk.org > Cc: Michael Lilja > Subject: [dpdk-dev] [PATCH v3] net/i40e: Improved FDIR programming times >=20 > Previously, the FDIR programming time is +11ms on i40e. > This patch will result in an average programming time of 22usec with a ma= x of > 60usec . >=20 > Signed-off-by: Michael Lilja >=20 > --- > v3: > * Code style fix > --- > drivers/net/i40e/i40e_fdir.c | 21 +++++++++++++-------- > 1 file changed, 13 insertions(+), 8 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_fdir.c b/drivers/net/i40e/i40e_fdir.c = index > 28cc554f5..2162443f5 100644 > --- a/drivers/net/i40e/i40e_fdir.c > +++ b/drivers/net/i40e/i40e_fdir.c > @@ -1296,23 +1296,28 @@ i40e_fdir_filter_programming(struct i40e_pf *pf, > rte_wmb(); > I40E_PCI_REG_WRITE(txq->qtx_tail, txq->tx_tail); >=20 > - for (i =3D 0; i < I40E_FDIR_WAIT_COUNT; i++) { > - rte_delay_us(I40E_FDIR_WAIT_INTERVAL_US); > + for (i =3D 0; i < (I40E_FDIR_WAIT_COUNT * > + I40E_FDIR_WAIT_INTERVAL_US); i++) { > if ((txdp->cmd_type_offset_bsz & > - > rte_cpu_to_le_64(I40E_TXD_QW1_DTYPE_MASK)) =3D=3D > - > rte_cpu_to_le_64(I40E_TX_DESC_DTYPE_DESC_DONE)) > + > rte_cpu_to_le_64(I40E_TXD_QW1_DTYPE_MASK)) =3D=3D > + > rte_cpu_to_le_64(I40E_TX_DESC_DTYPE_DESC_DONE)) > break; > + rte_delay_us(1); > } > - if (i >=3D I40E_FDIR_WAIT_COUNT) { > + if (i >=3D (I40E_FDIR_WAIT_COUNT * I40E_FDIR_WAIT_INTERVAL_US)) > { > PMD_DRV_LOG(ERR, "Failed to program FDIR filter:" > - " time out to get DD on tx queue."); > + " time out to get DD on tx queue."); > return -ETIMEDOUT; > } > /* totally delay 10 ms to check programming status*/ > - rte_delay_us((I40E_FDIR_WAIT_COUNT - i) * > I40E_FDIR_WAIT_INTERVAL_US); > + for (i =3D 0; i < (I40E_FDIR_WAIT_COUNT * > I40E_FDIR_WAIT_INTERVAL_US); i++) { > + if (i40e_check_fdir_programming_status(rxq) >=3D 0) { > + break; Braces {} should be removed here according to the coding style. Besides, I think we can return 0 here directly. > + } > + rte_delay_us(1); > + } > if (i40e_check_fdir_programming_status(rxq) < 0) { This condition can be removed, just keep the following error log. > PMD_DRV_LOG(ERR, "Failed to program FDIR filter:" > - " programming status reported."); > + " programming status reported."); > return -ENOSYS; > } >=20 > -- > 2.12.2 >=20 > Disclaimer: This email and any files transmitted with it may contain conf= idential > information intended for the addressee(s) only. The information is not to= be > surrendered or copied to unauthorized persons. If you have received this > communication in error, please notify the sender immediately and delete t= his > e-mail from your system.