From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 3D7FF2C13 for ; Wed, 28 Jun 2017 10:03:31 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jun 2017 01:03:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.40,274,1496127600"; d="scan'208";a="120129050" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga006.fm.intel.com with ESMTP; 28 Jun 2017 01:03:29 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 28 Jun 2017 01:03:29 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 28 Jun 2017 01:03:28 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.197]) by SHSMSX104.ccr.corp.intel.com ([10.239.4.70]) with mapi id 14.03.0319.002; Wed, 28 Jun 2017 16:03:14 +0800 From: "Xing, Beilei" To: "Chilikin, Andrey" , "dev@dpdk.org" CC: "Wu, Jingjing" Thread-Topic: [PATCH v3 1/2] net/i40e: extended list of operations for ddp processing Thread-Index: AQHS70pIH+6LgYAfT0u4q7bJk1UnQKI51PaQ//+J7ACAAIjCkA== Date: Wed, 28 Jun 2017 08:03:13 +0000 Message-ID: <94479800C636CB44BD422CB454846E0131FD8F92@SHSMSX101.ccr.corp.intel.com> References: <1495901077-11845-1-git-send-email-andrey.chilikin@intel.com> <1498570513-8592-2-git-send-email-andrey.chilikin@intel.com> <94479800C636CB44BD422CB454846E0131FD8F09@SHSMSX101.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/2] net/i40e: extended list of operations for ddp processing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jun 2017 08:03:32 -0000 Hi Andrey, > -----Original Message----- > From: Chilikin, Andrey > Sent: Wednesday, June 28, 2017 3:40 PM > To: Xing, Beilei ; dev@dpdk.org > Cc: Wu, Jingjing > Subject: RE: [PATCH v3 1/2] net/i40e: extended list of operations for ddp > processing >=20 > Hi Beilei, >=20 > > -----Original Message----- > > From: Xing, Beilei > > Sent: Wednesday, June 28, 2017 7:58 AM > > To: Chilikin, Andrey ; dev@dpdk.org > > Cc: Wu, Jingjing > > Subject: RE: [PATCH v3 1/2] net/i40e: extended list of operations for > > ddp processing > > > > Hi Andrey, > > > > > > + } > > > + else { > > > > Should be } else { here according to the coding style. >=20 > Will fix in v4 >=20 > > > --- a/drivers/net/i40e/rte_pmd_i40e.h > > > +++ b/drivers/net/i40e/rte_pmd_i40e.h > > > @@ -71,6 +71,8 @@ struct rte_pmd_i40e_mb_event_param { enum > > > rte_pmd_i40e_package_op { > > > RTE_PMD_I40E_PKG_OP_UNDEFINED =3D 0, > > > RTE_PMD_I40E_PKG_OP_WR_ADD, /**< load package and add to > > > info list */ > > > + RTE_PMD_I40E_PKG_OP_WR_DEL, /**< load package and delete > > > from info list */ > > > + RTE_PMD_I40E_PKG_OP_WR_ONLY, /**< load package without > > > modifying info > > > +list */ > > > > The only difference between RTE_PMD_I40E_PKG_OP_WR_ADD and > > RTE_PMD_I40E_PKG_OP_WR_ONLY is if need to change info list, right? Is > > there any difference between the profiles added? Do we need another > > CLI in testpmd to indicate how/when we need to use > RTE_PMD_I40E_PKG_OP_WR_ONLY? > > > I believe that existing testpmd CLI is enough for i40e as this 'if' state= ment if > (track_id && (op !=3D RTE_PMD_I40E_PKG_OP_WR_ONLY)) { will not register > profiles with track_id =3D=3D 0 >=20 OK, so track_id=3D0 is for RTE_PMD_I40E_PKG_OP_WR_ONLY. From the patch, it = seems we needn't new operation RTE_PMD_I40E_PKG_OP_WR_ONLY exposed to appli= cation as PMD can decide if register WR_ONLY profiles by track_id.=20