From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 52CC31396 for ; Wed, 13 Sep 2017 05:09:44 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Sep 2017 20:09:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.42,385,1500966000"; d="scan'208";a="150678492" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga005.fm.intel.com with ESMTP; 12 Sep 2017 20:09:44 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 12 Sep 2017 20:09:43 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.168]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.117]) with mapi id 14.03.0319.002; Wed, 13 Sep 2017 11:09:42 +0800 From: "Xing, Beilei" To: Adrien Mazarguil CC: "Wu, Jingjing" , "Chilikin, Andrey" , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 2/6] ethdev: add GTPC and GTPU items Thread-Index: AQHTJ8t6n9TTI9lzaEainQ5QUoWG4qKo0X+AgAf746D//8XIAIABlixA Date: Wed, 13 Sep 2017 03:09:41 +0000 Message-ID: <94479800C636CB44BD422CB454846E013201C0A3@SHSMSX101.ccr.corp.intel.com> References: <1503647430-93905-2-git-send-email-beilei.xing@intel.com> <1504783263-20575-1-git-send-email-beilei.xing@intel.com> <1504783263-20575-3-git-send-email-beilei.xing@intel.com> <20170907121949.GI4301@6wind.com> <94479800C636CB44BD422CB454846E013201B7A3@SHSMSX101.ccr.corp.intel.com> <20170912104648.GN2481@6wind.com> In-Reply-To: <20170912104648.GN2481@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiY2EyMDRhOWMtZjE1My00N2IyLWIxYzAtNTExZmI2ZGJiY2EwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE2LjUuOS4zIiwiVHJ1c3RlZExhYmVsSGFzaCI6IkR2VER4azBRTVpFQjB1aTA3djgyV0hjMzAwQmNac21ucU83M0RhRXhtXC84PSJ9 x-ctpclassification: CTP_IC dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add GTPC and GTPU items X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Sep 2017 03:09:45 -0000 Hi Adrien, > -----Original Message----- > From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com] > Sent: Tuesday, September 12, 2017 6:47 PM > To: Xing, Beilei > Cc: Wu, Jingjing ; Chilikin, Andrey > ; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add GTPC and GTPU items >=20 > Hi Beilei, >=20 > On Tue, Sep 12, 2017 at 06:40:50AM +0000, Xing, Beilei wrote: > > Hi Adrien, > > > > > -----Original Message----- > > > From: Adrien Mazarguil [mailto:adrien.mazarguil@6wind.com] > > > Sent: Thursday, September 7, 2017 8:20 PM > > > To: Xing, Beilei > > > Cc: Wu, Jingjing ; Chilikin, Andrey > > > ; dev@dpdk.org > > > Subject: Re: [dpdk-dev] [PATCH v2 2/6] ethdev: add GTPC and GTPU > > > items > > > > > > Hi Beilei, > > > > > > I assume this patch supersedes [1]? > > > > > > [1] http://dpdk.org/ml/archives/dev/2017-August/073501.html > > > > > > Thanks for merging testpmd and the API change as a single patch, I > > > still have a few comments, see below. > > > > > > (please add "flow API" somewhere in the title by the way) > > > > Thanks for all your comments. > > Yes, http://dpdk.org/ml/archives/dev/2017-August/073501.html is > superseded and did merging testpmd and API change. > > I will update title in next version. >=20 > All right, thanks. >=20 > > > On Thu, Sep 07, 2017 at 07:20:59PM +0800, Beilei Xing wrote: > > > > This patch adds GTPC and GTPU items to generic rte flow, and also > > > > exposes the following item fields through the flow command: > > > > > > > > - GTPC TEID > > > > - GTPU TEID > > > > > > > > Signed-off-by: Beilei Xing > > > > > > Won't there be a need to match nonspecific GTP traffic as well (both > > > GTP-C and GTP-U a once), since they use the same structure? > > > > > > I'm not familiar with the protocol at all so I wonder if you should > > > maybe leave the GTP item in addition to those two. > > > > > > > Agree, I will leave the GTP item in next version. > > > > GTP-C and GTP-U use the same structure, the difference between them is > UDP port, 2123 is for GTP-C, and 2152 is for GTP-U. > > Add GTP-C and GTP -U item since I want to design a user-friendly CLI. > > > > For example, if user wants to add such flow: assign GTP-U packets with > TEID 0x123456 to queue 14. > > Then use can use following CLI: > > flow create 0 ingress pattern eth / ipv4 / udp / gtpu teid is 0x123456 > > / end actions queue index 14 / end instead of below CLI to distinguish > GTP-C and GTP-U with UDP port: > > flow create 0 ingress pattern eth / ipv4 / udp dst spec 2125 dst mask > > 0 / gtp teid is 0x123456 / end actions queue index 14 / end >=20 > I agree with you from a usability standpoint it's much nicer. I have one > question though, could one send GTP-C / GTP-U traffic using nondefault UD= P > ports and expect hardware to match it without explicitly specifying a por= t in > the UDP item, that is, is there some property in GTP-C / GTP-U traffic ou= tside > the UDP port that would theoretically allow a host (even a stateful > one) to tell them apart? >=20 > If it really depends on the UDP port only, not specifying one will use > hardware defaults regardless of the item (GTP / GTP-U / GTP-C). However i= f > like VXLAN, this default value can be modified outside of rte_flow, most > users will have to specify it regardless in order to get consistent resul= ts > across various vendors/adapters. As far as I know, there's no other property in GTP-C / GTP-U traffic outsid= e the UDP port to distinguish GTP-C and GTP-U. And I don't think the value = can be modified by user just like VXLAN. >=20 > In any case I don't mind three items. GTP encompasses both GTP-U and > GTP-C (possibly two different UDP ports at once), while GTP-U and GTP-C > match exactly one. You only have to describe this properly in the > documentation. OK, I will describe it in documentation. Beilei