From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 3D8E8271 for ; Wed, 20 Dec 2017 04:13:13 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2017 19:13:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,429,1508828400"; d="scan'208";a="4255321" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga006.jf.intel.com with ESMTP; 19 Dec 2017 19:13:12 -0800 Received: from fmsmsx101.amr.corp.intel.com (10.18.124.199) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 19 Dec 2017 19:13:12 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx101.amr.corp.intel.com (10.18.124.199) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 19 Dec 2017 19:13:11 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.159]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.218]) with mapi id 14.03.0319.002; Wed, 20 Dec 2017 11:13:09 +0800 From: "Xing, Beilei" To: Olivier MATZ CC: "Wu, Jingjing" , "dev@dpdk.org" , "Chilikin, Andrey" Thread-Topic: [PATCH 1/2] mbuf: support PPPoE and L2TP in software packet type parser Thread-Index: AQHTeLG/0BV+oup5oke0hYG/iRVlz6NLj18A Date: Wed, 20 Dec 2017 03:13:08 +0000 Message-ID: <94479800C636CB44BD422CB454846E01320821F8@SHSMSX101.ccr.corp.intel.com> References: <1511863976-126599-1-git-send-email-beilei.xing@intel.com> <1511863976-126599-2-git-send-email-beilei.xing@intel.com> <20171219101106.yg4s6jpruyvs3b3t@glumotte.dev.6wind.com> In-Reply-To: <20171219101106.yg4s6jpruyvs3b3t@glumotte.dev.6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/2] mbuf: support PPPoE and L2TP in software packet type parser X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Dec 2017 03:13:14 -0000 > -----Original Message----- > From: Olivier MATZ [mailto:olivier.matz@6wind.com] > Sent: Tuesday, December 19, 2017 6:11 PM > To: Xing, Beilei > Cc: Wu, Jingjing ; dev@dpdk.org; Chilikin, Andrey > > Subject: Re: [PATCH 1/2] mbuf: support PPPoE and L2TP in software packet > type parser >=20 > Hi Beilei, >=20 > On Tue, Nov 28, 2017 at 06:12:55PM +0800, Beilei Xing wrote: > > Add support of PPPoE and L2TP in rte_net_get_ptype(). > > > > Signed-off-by: Beilei Xing > > --- > > lib/librte_mbuf/rte_mbuf_ptype.c | 2 ++ > > lib/librte_mbuf/rte_mbuf_ptype.h | 26 ++++++++++++++++++++++++++ > > 2 files changed, 28 insertions(+) > > > > diff --git a/lib/librte_mbuf/rte_mbuf_ptype.c > > b/lib/librte_mbuf/rte_mbuf_ptype.c > > index a623226..e0f2a92 100644 > > --- a/lib/librte_mbuf/rte_mbuf_ptype.c > > +++ b/lib/librte_mbuf/rte_mbuf_ptype.c > > @@ -47,6 +47,7 @@ const char *rte_get_ptype_l2_name(uint32_t ptype) > > case RTE_PTYPE_L2_ETHER_NSH: return "L2_ETHER_NSH"; > > case RTE_PTYPE_L2_ETHER_VLAN: return "L2_ETHER_VLAN"; > > case RTE_PTYPE_L2_ETHER_QINQ: return "L2_ETHER_QINQ"; > > + case RTE_PTYPE_L2_ETHER_PPPOE: return "L2_ETHER_PPPOE"; > > default: return "L2_UNKNOWN"; > > } > > } > > @@ -92,6 +93,7 @@ const char *rte_get_ptype_tunnel_name(uint32_t > ptype) > > case RTE_PTYPE_TUNNEL_GTPC: return "TUNNEL_GTPC"; > > case RTE_PTYPE_TUNNEL_GTPU: return "TUNNEL_GTPU"; > > case RTE_PTYPE_TUNNEL_ESP: return "TUNNEL_ESP"; > > + case RTE_PTYPE_TUNNEL_L2TP: return "TUNNEL_L2TP"; > > default: return "TUNNEL_UNKNOWN"; > > } > > } > > diff --git a/lib/librte_mbuf/rte_mbuf_ptype.h > > b/lib/librte_mbuf/rte_mbuf_ptype.h > > index 5c62435..256f024 100644 > > --- a/lib/librte_mbuf/rte_mbuf_ptype.h > > +++ b/lib/librte_mbuf/rte_mbuf_ptype.h > > @@ -153,6 +153,13 @@ extern "C" { > > */ > > #define RTE_PTYPE_L2_ETHER_QINQ 0x00000007 > > /** > > + * PPPOE packet type. > > + * > > + * Packet format: > > + * <'ether type'=3D[0x8863|0x8864]> > > + */ > > +#define RTE_PTYPE_L2_ETHER_PPPOE 0x00000008 > > +/** > > * Mask of layer 2 packet types. > > * It is used for outer packet for tunneling cases. > > */ > > @@ -426,6 +433,25 @@ extern "C" { > > */ > > #define RTE_PTYPE_TUNNEL_ESP 0x00009000 > > /** > > + * L2TP (Layer 2 Tunneling Protocol) tunnleing packet type. > > + * > > + * Packet format: > > + * <'ether type'=3D0x0800 > > + * | 'version'=3D4, 'protocol'=3D17> > > + * | 'destination port'=3D1701> > > + * or, > > + * <'ether type'=3D0x86DD > > + * | 'version'=3D6, 'next header'=3D17 > > + * | 'destination port'=3D1701> > > + * or, > > + * <'ether type'=3D0x0800 > > + * | 'version'=3D4, 'protocol'=3D115> > > + * or, > > + * <'ether type'=3D0x86DD > > + * | 'version'=3D6, 'protocol'=3D115> > > + */ > > +#define RTE_PTYPE_TUNNEL_L2TP 0x0000a000 > > +/** > > * Mask of tunneling packet types. > > */ > > #define RTE_PTYPE_TUNNEL_MASK 0x0000f000 >=20 > The patch looks good, but it should be renamed: >=20 > > mbuf: support PPPoE and L2TP in software packet type parser >=20 > The patch just adds the definition of the packet types, it does not add t= he > support of these packet types in the software parser, which is located in > rte_net_get_ptype(). >=20 > So, I suggest this title instead: >=20 > mbuf: add PPPoE and L2TP packet types Yes, thanks for the comments. Will update in the next version. >=20 >=20 > Thanks > Olivier