From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 1624F1B014; Thu, 4 Jan 2018 08:39:49 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jan 2018 23:39:48 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,506,1508828400"; d="scan'208";a="192263579" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 03 Jan 2018 23:39:47 -0800 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 3 Jan 2018 23:39:47 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 3 Jan 2018 23:39:47 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.159]) by shsmsx102.ccr.corp.intel.com ([169.254.2.189]) with mapi id 14.03.0319.002; Thu, 4 Jan 2018 15:39:45 +0800 From: "Xing, Beilei" To: Olivier Matz , "dev@dpdk.org" , "Wu, Jingjing" CC: "stable@dpdk.org" Thread-Topic: [PATCH v2] net/i40e: fix setting of MAC address on i40evf Thread-Index: AQHThJenvml0LKWZCkCcdtbJ0OjFeKNjVQCA Date: Thu, 4 Jan 2018 07:39:45 +0000 Message-ID: <94479800C636CB44BD422CB454846E0132087449@SHSMSX101.ccr.corp.intel.com> References: <20171214171531.10506-1-olivier.matz@6wind.com> <20180103133418.494-1-olivier.matz@6wind.com> In-Reply-To: <20180103133418.494-1-olivier.matz@6wind.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix setting of MAC address on i40evf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jan 2018 07:39:50 -0000 > -----Original Message----- > From: Olivier Matz [mailto:olivier.matz@6wind.com] > Sent: Wednesday, January 3, 2018 9:34 PM > To: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > > Cc: stable@dpdk.org > Subject: [PATCH v2] net/i40e: fix setting of MAC address on i40evf >=20 > When setting the MAC address, the ethdev layer copies the new mac > address in dev->data->mac_addrs[0] before calling the dev_ops. >=20 > Therefore, "is_same_ether_addr(mac_addr, dev->data->mac_addrs)" was > always true, and the MAC was never set. Remove this test to fix the issue= . >=20 > Fixes: 943c2d899a0c ("net/i40e: set VF MAC from VF") > Cc: stable@dpdk.org >=20 > Signed-off-by: Olivier Matz Acked-by: Beilei Xing , thanks for the fix.