From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 930131B1FA for ; Thu, 11 Jan 2018 07:56:00 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jan 2018 22:55:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,343,1511856000"; d="scan'208";a="20066510" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga004.fm.intel.com with ESMTP; 10 Jan 2018 22:55:58 -0800 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 10 Jan 2018 22:55:58 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 10 Jan 2018 22:55:58 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.159]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.152]) with mapi id 14.03.0319.002; Thu, 11 Jan 2018 14:55:56 +0800 From: "Xing, Beilei" To: Tonghao Zhang , "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 1/5] net/ixgbevf: unregister irq handler when other interrupts not allowed. Thread-Index: AQHThi82pUymc3ygHEGHkY2+iII1EqNuRMdQ Date: Thu, 11 Jan 2018 06:55:55 +0000 Message-ID: <94479800C636CB44BD422CB454846E013208AC48@SHSMSX101.ccr.corp.intel.com> References: <1515161439-4792-1-git-send-email-xiangxia.m.yue@gmail.com> In-Reply-To: <1515161439-4792-1-git-send-email-xiangxia.m.yue@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 1/5] net/ixgbevf: unregister irq handler when other interrupts not allowed. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jan 2018 06:56:01 -0000 > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tonghao Zhang > Sent: Friday, January 5, 2018 10:11 PM > To: dev@dpdk.org > Cc: Tonghao Zhang > Subject: [dpdk-dev] [PATCH 1/5] net/ixgbevf: unregister irq handler when > other interrupts not allowed. >=20 > When we bind the ixgbe VF (e.g 82599 card) to igb_uio and enable the rx- > interrupt, there will be more than one epoll_wait on intr_handle.fd. > One is in "eal-intr-thread" thread, and the others are in the thread whic= h call > the "rte_epoll_wait". The problem is that sometiems "eal-intr-thread" > thread will process the rx interrupt, and then rte_epoll_wait can't get t= he > event any more, and the packets may be lost. >=20 > We should unregister the status interrupt handler in "eal-intr-thread" > thread and the ixgbe pf is in the same case. >=20 > Signed-off-by: Tonghao Zhang The patch looks OK for me, the commit log can be reworded, for example, "we= " can be removed. Apart from that: Acked-by: Beilei Xing =20 > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) >=20 > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index 43e0132..e67389f 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -5049,6 +5049,15 @@ static int > ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, > } > ixgbevf_configure_msix(dev); >=20 > + if (!rte_intr_allow_others(intr_handle)) { > + rte_intr_callback_unregister(intr_handle, > + ixgbevf_dev_interrupt_handler, > + dev); > + if (dev->data->dev_conf.intr_conf.lsc !=3D 0) > + PMD_INIT_LOG(INFO, "lsc won't enable because of" > + " no intr multiplex"); > + } > + > /* When a VF port is bound to VFIO-PCI, only miscellaneous interrupt > * is mapped to VFIO vector 0 in eth_ixgbevf_dev_init( ). > * If previous VFIO interrupt mapping setting in > eth_ixgbevf_dev_init( ) @@ -5091,6 +5100,12 @@ static int > ixgbevf_dev_xstats_get_names(__rte_unused struct rte_eth_dev *dev, >=20 > ixgbe_dev_clear_queues(dev); >=20 > + if (!rte_intr_allow_others(intr_handle)) > + /* resume to the default handler */ > + rte_intr_callback_register(intr_handle, > + ixgbevf_dev_interrupt_handler, > + (void *)dev); > + > /* Clean datapath event and queue/vec mapping */ > rte_intr_efd_disable(intr_handle); > if (intr_handle->intr_vec !=3D NULL) { > -- > 1.8.3.1