From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <beilei.xing@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 281F61B1D0
 for <dev@dpdk.org>; Thu, 11 Jan 2018 08:27:00 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
 by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 10 Jan 2018 23:26:59 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.46,343,1511856000"; d="scan'208";a="165884731"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
 by orsmga004.jf.intel.com with ESMTP; 10 Jan 2018 23:26:58 -0800
Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Wed, 10 Jan 2018 23:26:58 -0800
Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by
 fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS)
 id 14.3.319.2; Wed, 10 Jan 2018 23:26:58 -0800
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.159]) by
 SHSMSX152.ccr.corp.intel.com ([169.254.6.93]) with mapi id 14.03.0319.002;
 Thu, 11 Jan 2018 15:26:56 +0800
From: "Xing, Beilei" <beilei.xing@intel.com>
To: Tonghao Zhang <xiangxia.m.yue@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Thread-Topic: [dpdk-dev] [PATCH 2/5] net/ixgbevf: set the inter-interrupt
 interval for EITR.
Thread-Index: AQHThi82NafNCLMBk0GZ47lqYf7n0aNuS/YA
Date: Thu, 11 Jan 2018 07:26:55 +0000
Message-ID: <94479800C636CB44BD422CB454846E013208ACB9@SHSMSX101.ccr.corp.intel.com>
References: <1515161439-4792-1-git-send-email-xiangxia.m.yue@gmail.com>
 <1515161439-4792-2-git-send-email-xiangxia.m.yue@gmail.com>
In-Reply-To: <1515161439-4792-2-git-send-email-xiangxia.m.yue@gmail.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-dev] [PATCH 2/5] net/ixgbevf: set the
	inter-interrupt	interval for EITR.
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Jan 2018 07:27:01 -0000



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Tonghao Zhang
> Sent: Friday, January 5, 2018 10:11 PM
> To: dev@dpdk.org
> Cc: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> Subject: [dpdk-dev] [PATCH 2/5] net/ixgbevf: set the inter-interrupt inte=
rval
> for EITR.
>=20
> Set EITR interval as default. This patch can improve the performance when
> we enable the rx-intrrupt to process the packets because we hope rx-
> intrrupt reduce CPU.
>=20
> The 200us value of EITR makes the performance better with the low CPU.
>=20
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
> ---
>  drivers/net/ixgbe/ixgbe_ethdev.c | 3 +++
>  1 file changed, 3 insertions(+)
>=20
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index e67389f..b20cab9 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -5780,6 +5780,9 @@ static void ixgbevf_set_vfta_all(struct rte_eth_dev
> *dev, bool on)
>  		if (vector_idx < base + intr_handle->nb_efd - 1)
>  			vector_idx++;
>  	}
> +
> +	IXGBE_WRITE_REG(hw, IXGBE_VTEITR(IXGBE_MISC_VEC_ID),
> +			IXGBE_EITR_INTERVAL_US(200) |

Is it possible to configure interval via DPDK configuration? Just like CONF=
IG_RTE_LIBRTE_I40E_ITR_INTERVAL for i40e.
Maybe the value is good for you but not suitable for other users.

Besides, seems the patches in the patchset have no dependency, needn't put =
them into one patchset, and then the Acked patch can be applied quickly.

> IXGBE_EITR_CNT_WDIS);
>  }
>=20
>  /**
> --
> 1.8.3.1