Re: [dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and FDIR

["Xing, Beilei" <beilei.xing@intel.com>]

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Friday, August 10, 2018 4:58 PM
> To: Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and
> FDIR
> 
> 10/08/2018 04:31, Xing, Beilei:
> > Hi Thomas,
> >
> > From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > > 06/08/2018 07:45, Beilei Xing:
> > > > This patch adds bitmask support for RSS, FDIR and FDIR flexible
> > > > payload.
> > > >
> > > > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> > >
> > > Flow director API is deprecated for almost 2 years:
> > > 	http://git.dpdk.org/dpdk/commit/?id=7fdcde6
> > > We asked several times to stop using it in i40e.
> > > It has not been listened.
> > > We have even accepted a workaround in flow_filtering example for i40e:
> > > 	http://git.dpdk.org/dpdk/commit/?id=9a93446
> > > We need to stop and move all to a common rte_flow API.
> > >
> > > As a consequence, I will be against this patch.
> > >
> >
> > It's not for deprecated flow director API, it's mainly for i40e private API
> rte_pmd_i40e_inset_set.
> > This patch is an extend of:
> > 	https://patches.dpdk.org/patch/33031/
> 
> It is a private API for flow director.
> I feel you play with me, it's worst.
> 

This API is designed when i40e supports DDP (Dynamic Device Personalization), which can support any protocol customer wants. Supported protocols in rte_flow are limited, if HW supports a new protocol, we should also change rte_flow and driver correspondingly each time, it's not dynamic then. So the API is designed, although it works for FDIR, but it's not designed for FDIR especially but for input set, sorry the title annoyed you, it's my fault. 
And you are right the private API is not a good way after all, I will abandon the patch first and investigate if there's other way. Thanks for the comments.