From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 95D252B83 for ; Mon, 13 Aug 2018 09:29:37 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Aug 2018 00:29:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,232,1531810800"; d="scan'208";a="80830863" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga001.fm.intel.com with ESMTP; 13 Aug 2018 00:29:36 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 13 Aug 2018 00:29:35 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.205]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.150]) with mapi id 14.03.0319.002; Mon, 13 Aug 2018 15:29:33 +0800 From: "Xing, Beilei" To: Thomas Monjalon CC: "dev@dpdk.org" , "Lu, Wenzhuo" , "Wu, Jingjing" Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and FDIR Thread-Index: AQHULUkF21YKgo8dWkGzdBpD39YeMKSx75IAgAZXlID//+iugIAFG7Wg Date: Mon, 13 Aug 2018 07:29:33 +0000 Message-ID: <94479800C636CB44BD422CB454846E013220E1E7@SHSMSX101.ccr.corp.intel.com> References: <1533534335-119817-1-git-send-email-beilei.xing@intel.com> <2252677.DSoj0ZM9iK@xps> <94479800C636CB44BD422CB454846E013220D55E@SHSMSX101.ccr.corp.intel.com> <12091596.jMvCybQCOU@xps> In-Reply-To: <12091596.jMvCybQCOU@xps> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and FDIR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Aug 2018 07:29:38 -0000 > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Friday, August 10, 2018 4:58 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Lu, Wenzhuo ; Wu, Jingjing > > Subject: Re: [dpdk-dev] [PATCH] app/testpmd: support bitmask for RSS and > FDIR >=20 > 10/08/2018 04:31, Xing, Beilei: > > Hi Thomas, > > > > From: Thomas Monjalon [mailto:thomas@monjalon.net] > > > 06/08/2018 07:45, Beilei Xing: > > > > This patch adds bitmask support for RSS, FDIR and FDIR flexible > > > > payload. > > > > > > > > Signed-off-by: Beilei Xing > > > > > > Flow director API is deprecated for almost 2 years: > > > http://git.dpdk.org/dpdk/commit/?id=3D7fdcde6 > > > We asked several times to stop using it in i40e. > > > It has not been listened. > > > We have even accepted a workaround in flow_filtering example for i40e= : > > > http://git.dpdk.org/dpdk/commit/?id=3D9a93446 > > > We need to stop and move all to a common rte_flow API. > > > > > > As a consequence, I will be against this patch. > > > > > > > It's not for deprecated flow director API, it's mainly for i40e private= API > rte_pmd_i40e_inset_set. > > This patch is an extend of: > > https://patches.dpdk.org/patch/33031/ >=20 > It is a private API for flow director. > I feel you play with me, it's worst. >=20 This API is designed when i40e supports DDP (Dynamic Device Personalization= ), which can support any protocol customer wants. Supported protocols in rt= e_flow are limited, if HW supports a new protocol, we should also change rt= e_flow and driver correspondingly each time, it's not dynamic then. So the = API is designed, although it works for FDIR, but it's not designed for FDIR= especially but for input set, sorry the title annoyed you, it's my fault.= =20 And you are right the private API is not a good way after all, I will aband= on the patch first and investigate if there's other way. Thanks for the com= ments.