From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id AD73A58D4 for ; Fri, 3 Jun 2016 05:14:08 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP; 02 Jun 2016 20:14:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,409,1459839600"; d="scan'208";a="990118145" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga002.jf.intel.com with ESMTP; 02 Jun 2016 20:14:07 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 2 Jun 2016 20:14:07 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 2 Jun 2016 20:14:06 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.150]) by shsmsx102.ccr.corp.intel.com ([169.254.2.220]) with mapi id 14.03.0248.002; Fri, 3 Jun 2016 11:13:57 +0800 From: "Xing, Beilei" To: "Lu, Wenzhuo" , "Wu, Jingjing" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] ethdev: change comments of VLAN type Thread-Index: AQHRtyBDdXVsfLjr1UivACECCNgyVJ/WkaEAgACLMIA= Date: Fri, 3 Jun 2016 03:13:57 +0000 Message-ID: <94479800C636CB44BD422CB454846E01374440@SHSMSX101.ccr.corp.intel.com> References: <1464247695-4694-1-git-send-email-beilei.xing@intel.com> <6A0DE07E22DDAD4C9103DF62FEBC090903478B0A@shsmsx102.ccr.corp.intel.com> In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC090903478B0A@shsmsx102.ccr.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] ethdev: change comments of VLAN type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Jun 2016 03:14:09 -0000 > -----Original Message----- > From: Lu, Wenzhuo > Sent: Friday, June 3, 2016 10:53 AM > To: Xing, Beilei ; Wu, Jingjing > Cc: dev@dpdk.org; Xing, Beilei > Subject: RE: [dpdk-dev] [PATCH] ethdev: change comments of VLAN type >=20 > Hi Beilei, >=20 >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing > > Sent: Thursday, May 26, 2016 3:28 PM > > To: Wu, Jingjing > > Cc: dev@dpdk.org; Xing, Beilei > > Subject: [dpdk-dev] [PATCH] ethdev: change comments of VLAN type > > > > If the packet carries a single VLAN header, it is treated as the outer = header. > > So change the comments of inner VLAN and outer VLAN. > > > > Signed-off-by: Beilei Xing > > --- > > doc/guides/rel_notes/release_16_07.rst | 3 +++ > > lib/librte_ether/rte_ethdev.h | 4 ++-- > > 2 files changed, 5 insertions(+), 2 deletions(-) > > > > diff --git a/doc/guides/rel_notes/release_16_07.rst > > b/doc/guides/rel_notes/release_16_07.rst > > index 30e78d4..29db86c 100644 > > --- a/doc/guides/rel_notes/release_16_07.rst > > +++ b/doc/guides/rel_notes/release_16_07.rst > > @@ -116,6 +116,9 @@ API Changes > > ibadcrc, ibadlen, imcasts, fdirmatch, fdirmiss, > > tx_pause_xon, rx_pause_xon, tx_pause_xoff, rx_pause_xoff. > > > > +* The comments of ``ETH_VLAN_TYPE_INNER`` and > > ``ETH_VLAN_TYPE_OUTER`` > > +in > > + ``rte_vlan_type`` are changed. > I think we need more explanation here. At least the info in the commit lo= g. Hi Wenzhuo, Thanks for your comments, and plan to combine this patch with i40 driver mo= dification, it should be better. Beilei