From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id B9DDAAD9A for ; Wed, 15 Jun 2016 04:56:46 +0200 (CEST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP; 14 Jun 2016 19:56:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.26,474,1459839600"; d="scan'208";a="122066552" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 14 Jun 2016 19:56:46 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 14 Jun 2016 19:56:45 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 14 Jun 2016 19:56:44 -0700 Received: from shsmsx103.ccr.corp.intel.com ([169.254.4.181]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.8]) with mapi id 14.03.0248.002; Wed, 15 Jun 2016 10:56:43 +0800 From: "Xing, Beilei" To: "Yigit, Ferruh" , "Lu, Wenzhuo" CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v2 00/30] ixgbe/base: update base driver Thread-Index: AQHRxgp+tb/8/9BSwkmdI8/vhIcRdp/oPueAgAAFOwCAAZBh0A== Date: Wed, 15 Jun 2016 02:56:43 +0000 Message-ID: <94479800C636CB44BD422CB454846E013976BA@SHSMSX103.ccr.corp.intel.com> References: <1462514861-29419-1-git-send-email-beilei.xing@intel.com> <1465887596-10346-1-git-send-email-beilei.xing@intel.com> <575FDE13.2060604@intel.com> <575FE276.2000306@intel.com> In-Reply-To: <575FE276.2000306@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmEwMzNkNGMtMTlkYS00MzEwLTg2MzUtMzE1NGZmNGFlZjY5IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX1BVQkxJQyJ9XX1dfSwiU3ViamVjdExhYmVscyI6W10sIlRNQ1ZlcnNpb24iOiIxNS45LjYuNiIsIlRydXN0ZWRMYWJlbEhhc2giOiJCYXlLM0U1eVhnREIwZzFTdUVWNkpTTjN4U1U0R3p5eUJ5RmtDRVoxbm1vPSJ9 x-ctpclassification: CTP_PUBLIC x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 00/30] ixgbe/base: update base driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2016 02:56:47 -0000 > -----Original Message----- > From: Yigit, Ferruh > Sent: Tuesday, June 14, 2016 6:55 PM > To: Xing, Beilei ; Lu, Wenzhuo > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 00/30] ixgbe/base: update base driver >=20 > On 6/14/2016 11:36 AM, Ferruh Yigit wrote: > > On 6/14/2016 7:59 AM, Beilei Xing wrote: > >> Update base driver for ixgbe, mainly work on new features and bug fixe= s. > >> > >> v2 changes: > >> Fix typos and update commit log. > >> Separate [patch 18/29] into two patches. > >> > > ... > >> > >> Acked-by: Helin Zhang > >> > > Series Reviewed-by Ferruh Yigit > > > Hi Beilei, >=20 > running check-git-log.sh scrip identified a few more issues in patch subj= ects. >=20 > Can you please send a new version of patchset addressing following issues= , sorry > for missing these at first review. >=20 > 1) Unify "X550EM_A" usage in patch subject and commit messages. > ixgbe/base: fix firmware commands on x550em_a > ixgbe/base: add KR support for X550EM_A devices >=20 > "X550em_a" seems preferred in old commits. >=20 > 2) Wrong headline lowercase: > ixgbe/base: allow setting mac anti spoofing per vf > ixgbe/base: add link mac setup for x550a SFP+ > ixgbe/base: add mac link setup for x550a SFP >=20 > mac and vf should be upercase >=20 > 3) Line too long: > Added support for the VLVF to be bypassed when adding/removing a > VFTA entry. >=20 > 4) Wrong tag: > Fixes: 86b8fb293fdf ("ixgbe/base: add sw-firmware sync for resour= ce > sharing) >=20 > missing a " at the end. >=20 >=20 > Regards, > ferruh Hi Ferruh, Thanks for your careful review:) After fixing some issues, there still exists warnings when running check-gi= t-log.sh. Can I ignore the two warnings? 1) Wrong headline format: ixgbe/base: fix firmware commands on X550em_a ixgbe/base: add KR support for X550em_a devices Seems it's caused by '_' in name ' X550em_a '. 2) Line too long: Fixes: 36f43e8679ae ("ixgbe/base: refactor manageability block comm= unication") Fixes: 86b8fb293fdf ("ixgbe/base: add sw-firmware sync for resource= sharing on X550em_a") Fixline shouldn't be separated into two lines, right?