From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id B7EF81B18C for ; Thu, 11 Oct 2018 09:00:49 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Oct 2018 00:00:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,367,1534834800"; d="scan'208";a="91046799" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 10 Oct 2018 23:56:51 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 10 Oct 2018 23:56:43 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.319.2; Wed, 10 Oct 2018 23:56:42 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.60]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.245]) with mapi id 14.03.0319.002; Thu, 11 Oct 2018 14:56:30 +0800 From: "Xing, Beilei" To: "Yigit, Ferruh" , "Pattan, Reshma" , Hemant Agrawal , Shreyansh Jain , Ashish Gupta , "Trahe, Fiona" , "De Lara Guarch, Pablo" , Akhil Goyal , "Doherty, Declan" , "Zhang, Roy Fan" , Jerin Jacob , Chas Williams , "Rahul Lakkireddy" , John Daley , Hyong Youb Kim , Gaetan Rivet , "Zhang, Qi Z" , "Wang, Xiao W" , "Lu, Wenzhuo" , "Ananyev, Konstantin" , Rasesh Mody , "Harish Patil" , Shahed Shaikh , Andrew Rybchenko , "Singh, Jasvinder" , "Dumitrescu, Cristian" , "Wiles, Keith" , Maxime Coquelin , "Bie, Tiwei" , "Wang, Zhihong" , Nipun Gupta , "Xu, Rosen" , "Zhang, Tianfei" , "Burakov, Anatoly" , Thomas Monjalon , "Rao, Nikhil" , Olivier Matz CC: "dev@dpdk.org" Thread-Topic: [PATCH] fix static variables Thread-Index: AQHUW4vQc3zCaoLPJ0Czdsug2Arm7aUZp2xg Date: Thu, 11 Oct 2018 06:56:28 +0000 Message-ID: <94479800C636CB44BD422CB454846E013CCDD0C1@SHSMSX101.ccr.corp.intel.com> References: <20181004034047.26824-1-ferruh.yigit@intel.com> In-Reply-To: <20181004034047.26824-1-ferruh.yigit@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] fix static variables X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Oct 2018 07:00:50 -0000 > -----Original Message----- > From: Yigit, Ferruh > Sent: Thursday, October 4, 2018 11:41 AM > To: Pattan, Reshma ; Hemant Agrawal > ; Shreyansh Jain ; > Ashish Gupta ; Trahe, Fiona > ; De Lara Guarch, Pablo > ; Akhil Goyal ; > Doherty, Declan ; Zhang, Roy Fan > ; Jerin Jacob ; > Chas Williams ; Rahul Lakkireddy > ; John Daley ; Hyong > Youb Kim ; Gaetan Rivet ; > Zhang, Qi Z ; Wang, Xiao W > ; Xing, Beilei ; Lu, > Wenzhuo ; Ananyev, Konstantin > ; Rasesh Mody > ; Harish Patil ; > Shahed Shaikh ; Andrew Rybchenko > ; Singh, Jasvinder > ; Dumitrescu, Cristian > ; Wiles, Keith ; > Maxime Coquelin ; Bie, Tiwei > ; Wang, Zhihong ; Nipun > Gupta ; Xu, Rosen ; Zhang, > Tianfei ; Burakov, Anatoly > ; Thomas Monjalon ; > Rao, Nikhil ; Olivier Matz > Cc: dev@dpdk.org; Yigit, Ferruh > Subject: [PATCH] fix static variables >=20 > Make variables static as much as possible. >=20 > For the ones can't be done static, prefix the variable name with > component name. >=20 > Also some cleanup and fix done related static usage while around. >=20 > Signed-off-by: Ferruh Yigit > --- > drivers/net/i40e/base/i40e_diag.c | 2 +- > drivers/net/i40e/base/i40e_diag.h | 2 - > drivers/net/i40e/i40e_flow.c | 4 +- > drivers/net/i40e/i40e_vf_representor.c | 2 +- For i40e part: Acked-by: Beilei Xing