From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 0C85E2C17 for ; Wed, 15 May 2019 08:36:13 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 May 2019 23:36:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,471,1549958400"; d="scan'208";a="171861220" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 14 May 2019 23:36:13 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 14 May 2019 23:36:12 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 14 May 2019 23:36:12 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.129]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.126]) with mapi id 14.03.0415.000; Wed, 15 May 2019 14:36:11 +0800 From: "Xing, Beilei" To: "Zhang, Qi Z" , "Lu, Wenzhuo" , "Yang, Qiming" , "Ananyev, Konstantin" CC: "dev@dpdk.org" Thread-Topic: [PATCH 0/3] fix invalid Tx threshhold setup Thread-Index: AQHVAluc6hLAcViOn02qqmB+fnhmiaZry67w Date: Wed, 15 May 2019 06:36:10 +0000 Message-ID: <94479800C636CB44BD422CB454846E013CDAF38B@SHSMSX101.ccr.corp.intel.com> References: <20190504092939.25326-1-qi.z.zhang@intel.com> In-Reply-To: <20190504092939.25326-1-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/3] fix invalid Tx threshhold setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 May 2019 06:36:14 -0000 > -----Original Message----- > From: Zhang, Qi Z > Sent: Saturday, May 4, 2019 5:30 PM > To: Xing, Beilei ; Lu, Wenzhuo > ; Yang, Qiming ; Ananyev, > Konstantin > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH 0/3] fix invalid Tx threshhold setup >=20 > When tx_free_thresh + tx_rs_thresh > nb_desc, it is possible that an > outdated DD status be checked as tx_next_dd, then segment fault happen > due to free a NULL mbuf pointer. >=20 > The issue usually happens with an aggresive tx_free_thresh, for example: >=20 > ./testpmd -c 0x3 -n 4 -- -i --rxq=3D16 --txq=3D16 --rxd=3D1024 --txd=3D10= 24 -- > txfreet=3D1020 >=20 > The patchset fix this issue on i40e, ixgbe and ice. >=20 > Qi Zhang (3): > net/i40e: fix invalid Tx threshold setup > net/ice: fix invalid Tx threshold setup > net/ixgbe: fix invalid Tx threshold setup >=20 > drivers/net/i40e/i40e_rxtx.c | 19 +++++++++++++++++-- > drivers/net/ice/ice_rxtx.c | 21 ++++++++++++++++++--- > drivers/net/ixgbe/ixgbe_rxtx.c | 19 +++++++++++++++++-- > 3 files changed, 52 insertions(+), 7 deletions(-) >=20 > -- > 2.13.6 Acked-by: Beilei Xing From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 8290FA00E6 for ; Wed, 15 May 2019 08:36:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 491342F7D; Wed, 15 May 2019 08:36:16 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 0C85E2C17 for ; Wed, 15 May 2019 08:36:13 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 May 2019 23:36:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,471,1549958400"; d="scan'208";a="171861220" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 14 May 2019 23:36:13 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 14 May 2019 23:36:12 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 14 May 2019 23:36:12 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.129]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.126]) with mapi id 14.03.0415.000; Wed, 15 May 2019 14:36:11 +0800 From: "Xing, Beilei" To: "Zhang, Qi Z" , "Lu, Wenzhuo" , "Yang, Qiming" , "Ananyev, Konstantin" CC: "dev@dpdk.org" Thread-Topic: [PATCH 0/3] fix invalid Tx threshhold setup Thread-Index: AQHVAluc6hLAcViOn02qqmB+fnhmiaZry67w Date: Wed, 15 May 2019 06:36:10 +0000 Message-ID: <94479800C636CB44BD422CB454846E013CDAF38B@SHSMSX101.ccr.corp.intel.com> References: <20190504092939.25326-1-qi.z.zhang@intel.com> In-Reply-To: <20190504092939.25326-1-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 0/3] fix invalid Tx threshhold setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190515063610.6l6oHZhF_8_FLwsfFXtmEX26lVBJ5kCRefLRnh--lgM@z> > -----Original Message----- > From: Zhang, Qi Z > Sent: Saturday, May 4, 2019 5:30 PM > To: Xing, Beilei ; Lu, Wenzhuo > ; Yang, Qiming ; Ananyev, > Konstantin > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH 0/3] fix invalid Tx threshhold setup >=20 > When tx_free_thresh + tx_rs_thresh > nb_desc, it is possible that an > outdated DD status be checked as tx_next_dd, then segment fault happen > due to free a NULL mbuf pointer. >=20 > The issue usually happens with an aggresive tx_free_thresh, for example: >=20 > ./testpmd -c 0x3 -n 4 -- -i --rxq=3D16 --txq=3D16 --rxd=3D1024 --txd=3D10= 24 -- > txfreet=3D1020 >=20 > The patchset fix this issue on i40e, ixgbe and ice. >=20 > Qi Zhang (3): > net/i40e: fix invalid Tx threshold setup > net/ice: fix invalid Tx threshold setup > net/ixgbe: fix invalid Tx threshold setup >=20 > drivers/net/i40e/i40e_rxtx.c | 19 +++++++++++++++++-- > drivers/net/ice/ice_rxtx.c | 21 ++++++++++++++++++--- > drivers/net/ixgbe/ixgbe_rxtx.c | 19 +++++++++++++++++-- > 3 files changed, 52 insertions(+), 7 deletions(-) >=20 > -- > 2.13.6 Acked-by: Beilei Xing