From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2DD8A0487 for ; Thu, 4 Jul 2019 04:17:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 975F01BE0; Thu, 4 Jul 2019 04:17:53 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 469AE1D7; Thu, 4 Jul 2019 04:17:52 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2019 19:17:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,449,1557212400"; d="scan'208";a="184902465" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 03 Jul 2019 19:17:50 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 3 Jul 2019 19:17:50 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 3 Jul 2019 19:17:49 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.134]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.240]) with mapi id 14.03.0439.000; Thu, 4 Jul 2019 10:17:48 +0800 From: "Xing, Beilei" To: "Zhang, Qi Z" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/i40e: fix unexpected skip fdir setup Thread-Index: AQHVMWkdiN2iSQUNL0Gj2vqxCIRj4qa5un9g Date: Thu, 4 Jul 2019 02:17:47 +0000 Message-ID: <94479800C636CB44BD422CB454846E013CE0163D@SHSMSX101.ccr.corp.intel.com> References: <20190703063449.23848-1-qi.z.zhang@intel.com> In-Reply-To: <20190703063449.23848-1-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix unexpected skip fdir setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhang, Qi Z > Sent: Wednesday, July 3, 2019 2:35 PM > To: Xing, Beilei > Cc: dev@dpdk.org; Zhang, Qi Z ; stable@dpdk.org > Subject: [PATCH] net/i40e: fix unexpected skip fdir setup >=20 > In i40e_flow_flush_fdir_filter, i40e_fdir_teardown is called, so > i40e_fdir_setup is required to be called before create a new fdir flow. >=20 > Fixes: 2e67a7fbf3ff ("net/i40e: config flow director automatically") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qi Zhang > --- > drivers/net/i40e/i40e_flow.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c = index > d62b32f17..48a6782a8 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -3175,8 +3175,8 @@ i40e_flow_parse_fdir_filter(struct rte_eth_dev > *dev, >=20 > cons_filter_type =3D RTE_ETH_FILTER_FDIR; >=20 > - if (dev->data->dev_conf.fdir_conf.mode !=3D > - RTE_FDIR_MODE_PERFECT) { > + if (dev->data->dev_conf.fdir_conf.mode !=3D > RTE_FDIR_MODE_PERFECT || > + pf->fdir.fdir_vsi =3D=3D NULL) { > /* Enable fdir when fdir flow is added at first time. */ > ret =3D i40e_fdir_setup(pf); > if (ret !=3D I40E_SUCCESS) { > -- > 2.13.6 Acked-by: Beilei Xing