From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 733F2A0471 for ; Thu, 18 Jul 2019 16:10:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6BDAF1041; Thu, 18 Jul 2019 16:10:44 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 4849DDE3; Thu, 18 Jul 2019 16:10:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2019 07:10:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,278,1559545200"; d="scan'208";a="191622792" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga004.fm.intel.com with ESMTP; 18 Jul 2019 07:10:41 -0700 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 18 Jul 2019 07:10:41 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 18 Jul 2019 07:10:40 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.134]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.110]) with mapi id 14.03.0439.000; Thu, 18 Jul 2019 22:10:39 +0800 From: "Xing, Beilei" To: "Lipiec, Herakliusz" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/i40e: add return check coverity Thread-Index: AQHVPWrg1WjHQHXyw0O8KqHIjrsj/qbQaaxg Date: Thu, 18 Jul 2019 14:10:38 +0000 Message-ID: <94479800C636CB44BD422CB454846E013CE07628@SHSMSX101.ccr.corp.intel.com> References: <20190718131623.22047-1-herakliusz.lipiec@intel.com> In-Reply-To: <20190718131623.22047-1-herakliusz.lipiec@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOTAzZTRmNTUtZTFkMS00ZDQ1LWEwOGUtODllZDNmZjE4NTBiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQkt6SWRRS1pcL1czRUpDS3NNWTQrNmVkSTFvXC9YZmQrYXhReWlcL2FFWkZHYmZvWVM1MFYxcStQMTJxdFFpcUV1ZCJ9 x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.600.7 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: add return check coverity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, > -----Original Message----- > From: Lipiec, Herakliusz > Sent: Thursday, July 18, 2019 9:16 PM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Lipiec, Herakliusz ; > stable@dpdk.org > Subject: [PATCH] net/i40e: add return check coverity >=20 > add return check for i40e_vsi_delete_mac call in > rte_pmd_i40e_remove_vf_mac_addr as per coverity issue. >=20 > Coverity Issue: 277224 Fix line should be added, thanks. > Cc: stable@dpdk.org > Signed-off-by: Herakliusz Lipiec > --- > drivers/net/i40e/rte_pmd_i40e.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/net/i40e/rte_pmd_i40e.c > b/drivers/net/i40e/rte_pmd_i40e.c index 24281c293..4c3c7088a 100644 > --- a/drivers/net/i40e/rte_pmd_i40e.c > +++ b/drivers/net/i40e/rte_pmd_i40e.c > @@ -581,6 +581,7 @@ rte_pmd_i40e_remove_vf_mac_addr(uint16_t port, > uint16_t vf_id, > struct i40e_pf_vf *vf; > struct i40e_vsi *vsi; > struct i40e_pf *pf; > + int ret; >=20 > if (i40e_validate_mac_addr((u8 *)mac_addr) !=3D I40E_SUCCESS) > return -EINVAL; > @@ -609,8 +610,9 @@ rte_pmd_i40e_remove_vf_mac_addr(uint16_t port, > uint16_t vf_id, > rte_ether_addr_copy(&null_mac_addr, &vf->mac_addr); >=20 > /* Remove the mac */ > - i40e_vsi_delete_mac(vsi, mac_addr); > - > + ret =3D i40e_vsi_delete_mac(vsi, mac_addr); > + if (ret !=3D I40E_SUCCESS) > + return ret; > return 0; > } >=20 > -- > 2.17.2