From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Zhu, TaoX" <taox.zhu@intel.com>, "Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: qinq strip is not supported by i40e
Date: Fri, 1 Nov 2019 02:02:23 +0000 [thread overview]
Message-ID: <94479800C636CB44BD422CB454846E013CE7E941@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20191030182131.72399-1-taox.zhu@intel.com>
> -----Original Message-----
> From: Zhu, TaoX
> Sent: Thursday, October 31, 2019 2:22 AM
> To: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Zhu, TaoX <taox.zhu@intel.com>
> Subject: [PATCH] net/i40e: qinq strip is not supported by i40e
>
> From: Zhu Tao <taox.zhu@intel.com>
>
> Qinq strip is not supported by i40e. When user tries to turn on QinQ strip, the
> driver gives unsupported return value and log.
>
> Signed-off-by: Zhu Tao <taox.zhu@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 77a46832c..ed8cbd849 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -3847,6 +3847,11 @@ i40e_vlan_offload_set(struct rte_eth_dev *dev, int
> mask)
> struct i40e_vsi *vsi = pf->main_vsi;
> struct rte_eth_rxmode *rxmode;
>
> + if (mask & ETH_QINQ_STRIP_MASK) {
> + PMD_DRV_LOG(ERR, "Strip qinq is not supported.");
> + return -ENOTSUP;
> + }
> +
> rxmode = &dev->data->dev_conf.rxmode;
> if (mask & ETH_VLAN_FILTER_MASK) {
> if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_FILTER)
> --
> 2.17.1
Acked-by: Beilei Xing <beilei.xing@intel.com>
next prev parent reply other threads:[~2019-11-01 2:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 18:21 taox.zhu
2019-11-01 2:02 ` Xing, Beilei [this message]
2019-11-04 3:25 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94479800C636CB44BD422CB454846E013CE7E941@SHSMSX101.ccr.corp.intel.com \
--to=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=taox.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).