* [dpdk-dev] [PATCH] net/i40e: qinq strip is not supported by i40e
@ 2019-10-30 18:21 taox.zhu
2019-11-01 2:02 ` Xing, Beilei
2019-11-04 3:25 ` Ye Xiaolong
0 siblings, 2 replies; 3+ messages in thread
From: taox.zhu @ 2019-10-30 18:21 UTC (permalink / raw)
To: beilei.xing, qi.z.zhang; +Cc: dev, Zhu Tao
From: Zhu Tao <taox.zhu@intel.com>
Qinq strip is not supported by i40e. When user tries to turn on
QinQ strip, the driver gives unsupported return value and log.
Signed-off-by: Zhu Tao <taox.zhu@intel.com>
---
drivers/net/i40e/i40e_ethdev.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 77a46832c..ed8cbd849 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -3847,6 +3847,11 @@ i40e_vlan_offload_set(struct rte_eth_dev *dev, int mask)
struct i40e_vsi *vsi = pf->main_vsi;
struct rte_eth_rxmode *rxmode;
+ if (mask & ETH_QINQ_STRIP_MASK) {
+ PMD_DRV_LOG(ERR, "Strip qinq is not supported.");
+ return -ENOTSUP;
+ }
+
rxmode = &dev->data->dev_conf.rxmode;
if (mask & ETH_VLAN_FILTER_MASK) {
if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_FILTER)
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: qinq strip is not supported by i40e
2019-10-30 18:21 [dpdk-dev] [PATCH] net/i40e: qinq strip is not supported by i40e taox.zhu
@ 2019-11-01 2:02 ` Xing, Beilei
2019-11-04 3:25 ` Ye Xiaolong
1 sibling, 0 replies; 3+ messages in thread
From: Xing, Beilei @ 2019-11-01 2:02 UTC (permalink / raw)
To: Zhu, TaoX, Zhang, Qi Z; +Cc: dev
> -----Original Message-----
> From: Zhu, TaoX
> Sent: Thursday, October 31, 2019 2:22 AM
> To: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Zhu, TaoX <taox.zhu@intel.com>
> Subject: [PATCH] net/i40e: qinq strip is not supported by i40e
>
> From: Zhu Tao <taox.zhu@intel.com>
>
> Qinq strip is not supported by i40e. When user tries to turn on QinQ strip, the
> driver gives unsupported return value and log.
>
> Signed-off-by: Zhu Tao <taox.zhu@intel.com>
> ---
> drivers/net/i40e/i40e_ethdev.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
> index 77a46832c..ed8cbd849 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -3847,6 +3847,11 @@ i40e_vlan_offload_set(struct rte_eth_dev *dev, int
> mask)
> struct i40e_vsi *vsi = pf->main_vsi;
> struct rte_eth_rxmode *rxmode;
>
> + if (mask & ETH_QINQ_STRIP_MASK) {
> + PMD_DRV_LOG(ERR, "Strip qinq is not supported.");
> + return -ENOTSUP;
> + }
> +
> rxmode = &dev->data->dev_conf.rxmode;
> if (mask & ETH_VLAN_FILTER_MASK) {
> if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_FILTER)
> --
> 2.17.1
Acked-by: Beilei Xing <beilei.xing@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [dpdk-dev] [PATCH] net/i40e: qinq strip is not supported by i40e
2019-10-30 18:21 [dpdk-dev] [PATCH] net/i40e: qinq strip is not supported by i40e taox.zhu
2019-11-01 2:02 ` Xing, Beilei
@ 2019-11-04 3:25 ` Ye Xiaolong
1 sibling, 0 replies; 3+ messages in thread
From: Ye Xiaolong @ 2019-11-04 3:25 UTC (permalink / raw)
To: taox.zhu; +Cc: beilei.xing, qi.z.zhang, dev
On 10/31, taox.zhu@intel.com wrote:
>From: Zhu Tao <taox.zhu@intel.com>
>
>Qinq strip is not supported by i40e. When user tries to turn on
>QinQ strip, the driver gives unsupported return value and log.
>
>Signed-off-by: Zhu Tao <taox.zhu@intel.com>
>---
> drivers/net/i40e/i40e_ethdev.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
>index 77a46832c..ed8cbd849 100644
>--- a/drivers/net/i40e/i40e_ethdev.c
>+++ b/drivers/net/i40e/i40e_ethdev.c
>@@ -3847,6 +3847,11 @@ i40e_vlan_offload_set(struct rte_eth_dev *dev, int mask)
> struct i40e_vsi *vsi = pf->main_vsi;
> struct rte_eth_rxmode *rxmode;
>
>+ if (mask & ETH_QINQ_STRIP_MASK) {
>+ PMD_DRV_LOG(ERR, "Strip qinq is not supported.");
>+ return -ENOTSUP;
>+ }
>+
> rxmode = &dev->data->dev_conf.rxmode;
> if (mask & ETH_VLAN_FILTER_MASK) {
> if (rxmode->offloads & DEV_RX_OFFLOAD_VLAN_FILTER)
>--
>2.17.1
>
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
Applied to dpdk-next-net-intel. Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-04 3:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-30 18:21 [dpdk-dev] [PATCH] net/i40e: qinq strip is not supported by i40e taox.zhu
2019-11-01 2:02 ` Xing, Beilei
2019-11-04 3:25 ` Ye Xiaolong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).