DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Cao, Yahui" <yahui.cao@intel.com>,
	"Yang, Qiming" <qiming.yang@intel.com>,
	"Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Zhang, Qi Z" <qi.z.zhang@intel.com>,
	"Ye,  Xiaolong" <xiaolong.ye@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/ice: fix tunnel profile existence check
Date: Tue, 5 Nov 2019 05:36:39 +0000	[thread overview]
Message-ID: <94479800C636CB44BD422CB454846E013CE80EC2@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20191105113655.71130-1-yahui.cao@intel.com>



> -----Original Message-----
> From: Cao, Yahui
> Sent: Tuesday, November 5, 2019 7:37 PM
> To: Yang, Qiming <qiming.yang@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Cao, Yahui
> <yahui.cao@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Subject: [PATCH] net/ice: fix tunnel profile existence check
> 

The patch looks OK for me.
Could you detail some description for the issue?

Beilei

> Fixes: d5ea22e9f4a5 ("net/ice: configure HW FDIR rule")
> Cc: beilei.xing@intel.com
> 
> Signed-off-by: Yahui Cao <yahui.cao@intel.com>
> ---
>  drivers/net/ice/ice_fdir_filter.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c
> index 736ccd54e..685383c1a 100644
> --- a/drivers/net/ice/ice_fdir_filter.c
> +++ b/drivers/net/ice/ice_fdir_filter.c
> @@ -646,7 +646,7 @@ ice_fdir_hw_tbl_conf(struct ice_pf *pf, struct ice_vsi
> *vsi,
>  			if (!memcmp(ori_seg, seg, sizeof(*seg)))
>  				return -EAGAIN;
>  		} else {
> -			if (!memcmp(ori_seg, &seg[1], sizeof(*seg)))
> +			if (!memcmp(&ori_seg[1], &seg[1], sizeof(*seg)))
>  				return -EAGAIN;
>  		}
> 
> --
> 2.17.1


  reply	other threads:[~2019-11-05  5:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-05 11:36 Yahui Cao
2019-11-05  5:36 ` Xing, Beilei [this message]
2019-11-05 13:37 ` [dpdk-dev] [PATCH v2] net/ice: fix FDIR " Yahui Cao
2019-11-07  6:12   ` Zhang, Qi Z
2019-11-07  7:49   ` Ye Xiaolong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=94479800C636CB44BD422CB454846E013CE80EC2@SHSMSX101.ccr.corp.intel.com \
    --to=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=wenzhuo.lu@intel.com \
    --cc=xiaolong.ye@intel.com \
    --cc=yahui.cao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).