From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E379A04A2; Tue, 5 Nov 2019 06:36:45 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 355662C15; Tue, 5 Nov 2019 06:36:44 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 947372BC7 for ; Tue, 5 Nov 2019 06:36:42 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Nov 2019 21:36:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,270,1569308400"; d="scan'208";a="191991928" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga007.jf.intel.com with ESMTP; 04 Nov 2019 21:36:41 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 4 Nov 2019 21:36:41 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 4 Nov 2019 21:36:40 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.213]) by shsmsx102.ccr.corp.intel.com ([169.254.2.108]) with mapi id 14.03.0439.000; Tue, 5 Nov 2019 13:36:39 +0800 From: "Xing, Beilei" To: "Cao, Yahui" , "Yang, Qiming" , "Lu, Wenzhuo" CC: "dev@dpdk.org" , "Zhang, Qi Z" , "Ye, Xiaolong" Thread-Topic: [PATCH] net/ice: fix tunnel profile existence check Thread-Index: AQHVk4x/RME3kj0zDUKQqKNayza0kKd8DoMA Date: Tue, 5 Nov 2019 05:36:39 +0000 Message-ID: <94479800C636CB44BD422CB454846E013CE80EC2@SHSMSX101.ccr.corp.intel.com> References: <20191105113655.71130-1-yahui.cao@intel.com> In-Reply-To: <20191105113655.71130-1-yahui.cao@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ice: fix tunnel profile existence check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Cao, Yahui > Sent: Tuesday, November 5, 2019 7:37 PM > To: Yang, Qiming ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Zhang, Qi Z ; Cao, Yahui > ; Ye, Xiaolong ; Xing, Beilei > > Subject: [PATCH] net/ice: fix tunnel profile existence check >=20 The patch looks OK for me. Could you detail some description for the issue? Beilei > Fixes: d5ea22e9f4a5 ("net/ice: configure HW FDIR rule") > Cc: beilei.xing@intel.com >=20 > Signed-off-by: Yahui Cao > --- > drivers/net/ice/ice_fdir_filter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir= _filter.c > index 736ccd54e..685383c1a 100644 > --- a/drivers/net/ice/ice_fdir_filter.c > +++ b/drivers/net/ice/ice_fdir_filter.c > @@ -646,7 +646,7 @@ ice_fdir_hw_tbl_conf(struct ice_pf *pf, struct ice_vs= i > *vsi, > if (!memcmp(ori_seg, seg, sizeof(*seg))) > return -EAGAIN; > } else { > - if (!memcmp(ori_seg, &seg[1], sizeof(*seg))) > + if (!memcmp(&ori_seg[1], &seg[1], sizeof(*seg))) > return -EAGAIN; > } >=20 > -- > 2.17.1