Re: [dpdk-dev] [PATCH] net/i40e: Add new customized pctype for l2tpv3

["Xing, Beilei" <beilei.xing@intel.com>]

> -----Original Message-----
> From: Sexton, Rory <rory.sexton@intel.com>
> Sent: Friday, December 13, 2019 3:18 AM
> To: Xing, Beilei <beilei.xing@intel.com>; dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; adrien.mazarguil@6wind.com;
> Jagus, DariuszX <dariuszx.jagus@intel.com>
> Subject: RE: [PATCH] net/i40e: Add new customized pctype for l2tpv3
> 
> Hi Beilei,
> 
> See comments below.
> 
> Regards,
> Rory
> 
> > > Subject: [PATCH] net/i40e: Add new customized pctype for l2tpv3
> > It's not only add new customized pctype, but mainly enable FDIR for l2ipv3,
> so how about " net/i40e: support FDIR for L2TPv3"?
> >
> > Detailed commit log is also needed.
> 
> Of course can update this in v2.
> 
> > > +/* A structure used to define the input for L2TPv3 flow */ struct
> > > +i40e_l2tpv3_flow {
> >
> > Seems missed struct rte_eth_ipv4_flow or struct rte_eth_ipv6_flow here?
> >
> 
> I'm not convinced we need struct rte_eth_ipv4_flow or struct
> rte_eth_ipv6_flow to be part of the struct i40e_l2tpv3_flow.
> The rte_eth_ipv4/6_flow struct will be included in the flow director pattern
> from the following additions.
> Please advice so I can update in a v2 of the patch if required.

Please refer to union i40e_fdir_flow: A union contains the inputs for all types of flow items in flows need to be in big endian.
Pattern is part of rte flow, but not the packet sent to HW to create/destroy a FDIR rule.

Beilei

> 
> +static enum rte_flow_item_type pattern_fdir_ipv4_l2tpv3[] = {
> +       RTE_FLOW_ITEM_TYPE_ETH,
> +       RTE_FLOW_ITEM_TYPE_IPV4,
> +       RTE_FLOW_ITEM_TYPE_L2TPV3,
> +       RTE_FLOW_ITEM_TYPE_END,
> +};
> +
> +static enum rte_flow_item_type pattern_fdir_ipv6_l2tpv3[] = {
> +       RTE_FLOW_ITEM_TYPE_ETH,
> +       RTE_FLOW_ITEM_TYPE_IPV6,
> +       RTE_FLOW_ITEM_TYPE_L2TPV3,
> +       RTE_FLOW_ITEM_TYPE_END,
> +};
>