From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7AFA1A04F1; Fri, 13 Dec 2019 18:33:19 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5D3751C0AA; Fri, 13 Dec 2019 18:33:18 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id CF28E1C08E for ; Fri, 13 Dec 2019 18:33:16 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Dec 2019 09:33:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,309,1571727600"; d="scan'208";a="388741815" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga005.jf.intel.com with ESMTP; 13 Dec 2019 09:33:15 -0800 Received: from fmsmsx115.amr.corp.intel.com (10.18.116.19) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 13 Dec 2019 09:33:14 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx115.amr.corp.intel.com (10.18.116.19) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 13 Dec 2019 09:33:14 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.19]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.214]) with mapi id 14.03.0439.000; Sat, 14 Dec 2019 01:33:12 +0800 From: "Xing, Beilei" To: "Sexton, Rory" , "dev@dpdk.org" CC: "Zhang, Qi Z" , "adrien.mazarguil@6wind.com" , "Jagus, DariuszX" Thread-Topic: [PATCH] net/i40e: Add new customized pctype for l2tpv3 Thread-Index: AQHVqq1MvC+zG0sRoEGjgDeySHEL/Ke1kESggAHiGYCAAO1+cA== Date: Fri, 13 Dec 2019 17:33:11 +0000 Message-ID: <94479800C636CB44BD422CB454846E013CEA6079@SHSMSX101.ccr.corp.intel.com> References: <20191204141055.3647-1-rory.sexton@intel.com> <20191204141055.3647-2-rory.sexton@intel.com> <94479800C636CB44BD422CB454846E013CEA4464@SHSMSX101.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWJiYmI3MzktYTA1NC00MTQ3LWIxYjYtMjk1NzkyZmExMzJjIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieVdBN2hVOFwveExYQm1aaVhGK050bjhrcHE5cjlEMDVZd0pRbzBMbDFJRW5jNFFFT2NGa3BJbVdwcVhIZ2ZkTDUifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e: Add new customized pctype for l2tpv3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Sexton, Rory > Sent: Friday, December 13, 2019 3:18 AM > To: Xing, Beilei ; dev@dpdk.org > Cc: Zhang, Qi Z ; adrien.mazarguil@6wind.com; > Jagus, DariuszX > Subject: RE: [PATCH] net/i40e: Add new customized pctype for l2tpv3 >=20 > Hi Beilei, >=20 > See comments below. >=20 > Regards, > Rory >=20 > > > Subject: [PATCH] net/i40e: Add new customized pctype for l2tpv3 > > It's not only add new customized pctype, but mainly enable FDIR for l2i= pv3, > so how about " net/i40e: support FDIR for L2TPv3"? > > > > Detailed commit log is also needed. >=20 > Of course can update this in v2. >=20 > > > +/* A structure used to define the input for L2TPv3 flow */ struct > > > +i40e_l2tpv3_flow { > > > > Seems missed struct rte_eth_ipv4_flow or struct rte_eth_ipv6_flow here? > > >=20 > I'm not convinced we need struct rte_eth_ipv4_flow or struct > rte_eth_ipv6_flow to be part of the struct i40e_l2tpv3_flow. > The rte_eth_ipv4/6_flow struct will be included in the flow director patt= ern > from the following additions. > Please advice so I can update in a v2 of the patch if required. Please refer to union i40e_fdir_flow: A union contains the inputs for all t= ypes of flow items in flows need to be in big endian. Pattern is part of rte flow, but not the packet sent to HW to create/destro= y a FDIR rule. Beilei >=20 > +static enum rte_flow_item_type pattern_fdir_ipv4_l2tpv3[] =3D { > + RTE_FLOW_ITEM_TYPE_ETH, > + RTE_FLOW_ITEM_TYPE_IPV4, > + RTE_FLOW_ITEM_TYPE_L2TPV3, > + RTE_FLOW_ITEM_TYPE_END, > +}; > + > +static enum rte_flow_item_type pattern_fdir_ipv6_l2tpv3[] =3D { > + RTE_FLOW_ITEM_TYPE_ETH, > + RTE_FLOW_ITEM_TYPE_IPV6, > + RTE_FLOW_ITEM_TYPE_L2TPV3, > + RTE_FLOW_ITEM_TYPE_END, > +}; >=20