From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46D6FA04F0; Fri, 27 Dec 2019 06:37:50 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B95711BFE7; Fri, 27 Dec 2019 06:37:48 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 13AED1BFE5 for ; Fri, 27 Dec 2019 06:37:46 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Dec 2019 21:37:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,361,1571727600"; d="scan'208";a="392527610" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 26 Dec 2019 21:37:45 -0800 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 26 Dec 2019 21:37:44 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 26 Dec 2019 21:37:44 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.19]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.214]) with mapi id 14.03.0439.000; Fri, 27 Dec 2019 13:37:42 +0800 From: "Xing, Beilei" To: "Ye, Xiaolong" , "Zhang, Qi Z" CC: "dev@dpdk.org" , "Stillwell Jr, Paul M" , "Loktionov, Aleksandr" Thread-Topic: [PATCH v3 36/36] net/i40e/base: add new link speed constants Thread-Index: AQHVs7uUL0c0//pFykGtU8NlwJCDXqfNhXPw Date: Fri, 27 Dec 2019 05:37:41 +0000 Message-ID: <94479800C636CB44BD422CB454846E013CEB3654@SHSMSX101.ccr.corp.intel.com> References: <20191202074935.97629-1-xiaolong.ye@intel.com> <20191216024336.174318-1-xiaolong.ye@intel.com> <20191216024336.174318-37-xiaolong.ye@intel.com> In-Reply-To: <20191216024336.174318-37-xiaolong.ye@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 36/36] net/i40e/base: add new link speed constants X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ye, Xiaolong > Sent: Monday, December 16, 2019 10:44 AM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Stillwell Jr, Paul M ; Y= e, > Xiaolong ; Loktionov, Aleksandr > > Subject: [PATCH v3 36/36] net/i40e/base: add new link speed constants >=20 > This patch fixes 'NIC Link is Up, Unknown bps' message in dmesg for 2.5Gb= /5Gb > speeds. This problem is fixed by adding constants for > VIRTCHNL_LINK_SPEED_2_5GB and VIRTCHNL_LINK_SPEED_5GB. >=20 It's a fix patch, fix line is needed? The same comment is also for patch 27= /36, 25/36, 21/36, 14/36. > Signed-off-by: Aleksandr Loktionov > Signed-off-by: Xiaolong Ye > --- > drivers/net/i40e/base/i40e_prototype.h | 4 ++++ > drivers/net/i40e/base/virtchnl.h | 4 ++++ > 2 files changed, 8 insertions(+) >=20 > diff --git a/drivers/net/i40e/base/i40e_prototype.h > b/drivers/net/i40e/base/i40e_prototype.h > index 0f06e3262..d8ab3ea0a 100644 > --- a/drivers/net/i40e/base/i40e_prototype.h > +++ b/drivers/net/i40e/base/i40e_prototype.h > @@ -505,6 +505,10 @@ i40e_virtchnl_link_speed(enum i40e_aq_link_speed > link_speed) > return VIRTCHNL_LINK_SPEED_100MB; > case I40E_LINK_SPEED_1GB: > return VIRTCHNL_LINK_SPEED_1GB; > + case I40E_LINK_SPEED_2_5GB: > + return VIRTCHNL_LINK_SPEED_2_5GB; > + case I40E_LINK_SPEED_5GB: > + return VIRTCHNL_LINK_SPEED_5GB; > case I40E_LINK_SPEED_10GB: > return VIRTCHNL_LINK_SPEED_10GB; > case I40E_LINK_SPEED_40GB: > diff --git a/drivers/net/i40e/base/virtchnl.h b/drivers/net/i40e/base/vir= tchnl.h > index c613d4761..92515bf34 100644 > --- a/drivers/net/i40e/base/virtchnl.h > +++ b/drivers/net/i40e/base/virtchnl.h > @@ -53,12 +53,14 @@ enum virtchnl_status_code { #define > VIRTCHNL_ERR_PARAM VIRTCHNL_STATUS_ERR_PARAM #define > VIRTCHNL_STATUS_NOT_SUPPORTED > VIRTCHNL_STATUS_ERR_NOT_SUPPORTED >=20 > +#define VIRTCHNL_LINK_SPEED_2_5GB_SHIFT 0x0 > #define VIRTCHNL_LINK_SPEED_100MB_SHIFT 0x1 > #define VIRTCHNL_LINK_SPEED_1000MB_SHIFT 0x2 > #define VIRTCHNL_LINK_SPEED_10GB_SHIFT 0x3 > #define VIRTCHNL_LINK_SPEED_40GB_SHIFT 0x4 > #define VIRTCHNL_LINK_SPEED_20GB_SHIFT 0x5 > #define VIRTCHNL_LINK_SPEED_25GB_SHIFT 0x6 > +#define VIRTCHNL_LINK_SPEED_5GB_SHIFT 0x7 >=20 > enum virtchnl_link_speed { > VIRTCHNL_LINK_SPEED_UNKNOWN =3D 0, > @@ -68,6 +70,8 @@ enum virtchnl_link_speed { > VIRTCHNL_LINK_SPEED_40GB =3D > BIT(VIRTCHNL_LINK_SPEED_40GB_SHIFT), > VIRTCHNL_LINK_SPEED_20GB =3D > BIT(VIRTCHNL_LINK_SPEED_20GB_SHIFT), > VIRTCHNL_LINK_SPEED_25GB =3D > BIT(VIRTCHNL_LINK_SPEED_25GB_SHIFT), > + VIRTCHNL_LINK_SPEED_2_5GB =3D > BIT(VIRTCHNL_LINK_SPEED_2_5GB_SHIFT), > + VIRTCHNL_LINK_SPEED_5GB =3D > BIT(VIRTCHNL_LINK_SPEED_5GB_SHIFT), > }; >=20 > /* for hsplit_0 field of Rx HMC context */ > -- > 2.17.1