From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>, "Cao, Yahui" <yahui.cao@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/ice: fix wrong GTP-U fdir profile
Date: Fri, 17 Jan 2020 07:07:56 +0000 [thread overview]
Message-ID: <94479800C636CB44BD422CB454846E013CECC81C@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20200117062033.12298-1-qi.z.zhang@intel.com>
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Friday, January 17, 2020 2:21 PM
> To: Cao, Yahui <yahui.cao@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/ice: fix wrong GTP-U fdir profile
>
> A GTP-U fdir profile should be regarded as a tunnel type, or the profile target
> to inner IPv4 will also cover inner IPv6 packet type due to some side effect.
>
> Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel")
> Cc: stable@dpdk.org
>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
> drivers/net/ice/ice_fdir_filter.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir_filter.c
> index fa8707455..4c5ddfbdb 100644
> --- a/drivers/net/ice/ice_fdir_filter.c
> +++ b/drivers/net/ice/ice_fdir_filter.c
> @@ -987,6 +987,7 @@ ice_fdir_input_set_conf(struct ice_pf *pf, enum
> ice_fltr_ptype flow,
> ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_GTPU_EH |
> ICE_FLOW_SEG_HDR_GTPU_IP |
> ICE_FLOW_SEG_HDR_IPV4);
> + is_tunnel = true;
I think we should fix in ice_fdir_is_tunnel_profile function.
BR,
Beilei
> break;
> default:
> PMD_DRV_LOG(ERR, "not supported filter type.");
> --
> 2.13.6
next prev parent reply other threads:[~2020-01-17 7:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-17 6:20 Qi Zhang
2020-01-17 7:07 ` Xing, Beilei [this message]
2020-01-20 5:08 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94479800C636CB44BD422CB454846E013CECC81C@SHSMSX101.ccr.corp.intel.com \
--to=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=yahui.cao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).