From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C65C8A051A; Fri, 17 Jan 2020 08:10:47 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4517A1D15A; Fri, 17 Jan 2020 08:10:47 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id EAB391D159; Fri, 17 Jan 2020 08:10:45 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Jan 2020 23:08:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,329,1574150400"; d="scan'208";a="214380143" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga007.jf.intel.com with ESMTP; 16 Jan 2020 23:08:04 -0800 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Jan 2020 23:08:04 -0800 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 16 Jan 2020 23:08:04 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.30]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.210]) with mapi id 14.03.0439.000; Fri, 17 Jan 2020 15:07:57 +0800 From: "Xing, Beilei" To: "Zhang, Qi Z" , "Cao, Yahui" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH] net/ice: fix wrong GTP-U fdir profile Thread-Index: AQHVzP3IQq6kMAYmC0mhdKaBGr6c7qfub2jA Date: Fri, 17 Jan 2020 07:07:56 +0000 Message-ID: <94479800C636CB44BD422CB454846E013CECC81C@SHSMSX101.ccr.corp.intel.com> References: <20200117062033.12298-1-qi.z.zhang@intel.com> In-Reply-To: <20200117062033.12298-1-qi.z.zhang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/ice: fix wrong GTP-U fdir profile X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Zhang, Qi Z > Sent: Friday, January 17, 2020 2:21 PM > To: Cao, Yahui ; Xing, Beilei > Cc: dev@dpdk.org; Zhang, Qi Z ; stable@dpdk.org > Subject: [PATCH] net/ice: fix wrong GTP-U fdir profile >=20 > A GTP-U fdir profile should be regarded as a tunnel type, or the profile = target > to inner IPv4 will also cover inner IPv6 packet type due to some side eff= ect. >=20 > Fixes: efc16c621415 ("net/ice: support flow director GTPU tunnel") > Cc: stable@dpdk.org >=20 > Signed-off-by: Qi Zhang > --- > drivers/net/ice/ice_fdir_filter.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/drivers/net/ice/ice_fdir_filter.c b/drivers/net/ice/ice_fdir= _filter.c > index fa8707455..4c5ddfbdb 100644 > --- a/drivers/net/ice/ice_fdir_filter.c > +++ b/drivers/net/ice/ice_fdir_filter.c > @@ -987,6 +987,7 @@ ice_fdir_input_set_conf(struct ice_pf *pf, enum > ice_fltr_ptype flow, > ICE_FLOW_SET_HDRS(seg, ICE_FLOW_SEG_HDR_GTPU_EH | > ICE_FLOW_SEG_HDR_GTPU_IP | > ICE_FLOW_SEG_HDR_IPV4); > + is_tunnel =3D true; I think we should fix in ice_fdir_is_tunnel_profile function. BR, Beilei > break; > default: > PMD_DRV_LOG(ERR, "not supported filter type."); > -- > 2.13.6