From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 294ADA0525; Wed, 22 Jan 2020 05:48:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B97962A62; Wed, 22 Jan 2020 05:48:19 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 41C50E07 for ; Wed, 22 Jan 2020 05:48:18 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jan 2020 20:48:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,348,1574150400"; d="scan'208";a="425730437" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 21 Jan 2020 20:48:16 -0800 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Jan 2020 20:48:16 -0800 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 21 Jan 2020 20:48:16 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.30]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.28]) with mapi id 14.03.0439.000; Wed, 22 Jan 2020 12:48:15 +0800 From: "Xing, Beilei" To: "Ye, Xiaolong" , "Zhang, Qi Z" CC: "dev@dpdk.org" Thread-Topic: [PATCH] net/i40e/base: skip further adminq init for VF Thread-Index: AQHV0Nk53BAYSrkpPUqelrKUw32lf6f2HJBA Date: Wed, 22 Jan 2020 04:48:14 +0000 Message-ID: <94479800C636CB44BD422CB454846E013CECFDA5@SHSMSX101.ccr.corp.intel.com> References: <20200122035810.154767-1-xiaolong.ye@intel.com> In-Reply-To: <20200122035810.154767-1-xiaolong.ye@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] net/i40e/base: skip further adminq init for VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ye, Xiaolong > Sent: Wednesday, January 22, 2020 11:58 AM > To: Xing, Beilei ; Zhang, Qi Z > Cc: dev@dpdk.org; Ye, Xiaolong > Subject: [PATCH] net/i40e/base: skip further adminq init for VF >=20 > Since VF has no need of firmware, we can skip further adminq init which > involves firmware operation, this patch fixes the testpmd segfault issue = when > starting with i40e VF. >=20 > Fixes: d5e1a149362e ("net/i40e/base: check MAC type") >=20 > Signed-off-by: Xiaolong Ye > --- > drivers/net/i40e/base/i40e_adminq.c | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/drivers/net/i40e/base/i40e_adminq.c > b/drivers/net/i40e/base/i40e_adminq.c > index 221c327d1..bc9ef3c87 100644 > --- a/drivers/net/i40e/base/i40e_adminq.c > +++ b/drivers/net/i40e/base/i40e_adminq.c > @@ -673,6 +673,9 @@ enum i40e_status_code i40e_init_adminq(struct > i40e_hw *hw) > if (ret_code !=3D I40E_SUCCESS) > goto init_adminq_free_asq; >=20 > + if (i40e_is_vf(hw)) > + goto init_adminq_exit; > + > /* There are some cases where the firmware may not be quite ready > * for AdminQ operations, so we retry the AdminQ setup a few times > * if we see timeouts in this first AQ call. > -- > 2.17.1 Acked-by: Beilei Xing