From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A2DBA00C3; Tue, 1 Feb 2022 15:12:37 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37F1940698; Tue, 1 Feb 2022 15:12:37 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 3590A40691 for ; Tue, 1 Feb 2022 15:12:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1643724756; x=1675260756; h=message-id:date:to:cc:references:from:subject: in-reply-to:content-transfer-encoding:mime-version; bh=3rnwEbjwUlJcBZxCZh3nVGPQJalsaqhk5mM7ruxZ7GA=; b=eUZf/+H1ly2wzttZU8/OMenZeA8EsWnuzsfrTYvjDXvES2zlHBSHvr3Y kdORVGbGQKsmuJ0XwVyDoO249SmNxdCh+pWir4DepjBtuoHBP4MKTTY0V HEYyNsx+ZpGoSBsV6hVlMsylfx2n8NCXb2PXPKvIlH8tccD49QZXKQRc+ h+3s2y0J/tDO/+vh7nfRA4szJoxaWtMzfPwVUZQkTuznL2KeuvvWxapMk nGnaRC9t5/Yb17T+syNJUB92eooOI+hP8Vj57RLS/mYT26bOHEKW4OxTo cZxGICXxKTkqaTEw1nWoP1LSAsvFaxYozZJUza69vrYFuvIol7HalilxO Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10244"; a="247913915" X-IronPort-AV: E=Sophos;i="5.88,334,1635231600"; d="scan'208";a="247913915" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2022 06:12:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,334,1635231600"; d="scan'208";a="619801134" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by FMSMGA003.fm.intel.com with ESMTP; 01 Feb 2022 06:12:24 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 1 Feb 2022 06:12:23 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Tue, 1 Feb 2022 06:12:23 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Tue, 1 Feb 2022 06:12:23 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.173) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Tue, 1 Feb 2022 06:12:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DOIMt9b2hxytPONfLx3qtslQX3CKseQNfXFy2L+KPOdAD+xUCxHHtZR6Tb/tMoJ97bRAtHGlMesmqcW48rxMkh9gGaHQfHIOqmy7p4ww+qxg2OeGO0RX1UNzbgEg04kPF+ATc1klvO+f+wxgBHNoWUZZ/NZXLiTLvXKjZRp/eOya1rf2gI68opGyxxmi8+hTC2jOoIvuxSpzbMLVOZ5c0QAt6/gP9cHkiC0KoGlCfn/vN4OkCh77quc/7lBXdT8D6OFRj/sfJ/N9DguyXvwJUvyQ2CwJfqRjtfHjg5uQrUIN15Yl8FKUXRWtf91nZmpbZuGT46Li0KGyuVQLGC0Nzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/OYxr1tC5EH7rlE41mUWWVr1NzgXWbm3/OBlk1mTKMM=; b=iDwxtK3QUErw1T5WloPDJRjC98jnnoHUePb8jdszd5ARF1B7yxV6XWW+f9Mw9ymJn7XYpckOTeIUuNBbdhBCNNKgsm7b2XHDQsib+HaPWmNDvSmeUQPWh+q19f4gS08LBrr5+bt+OPgsCJBjU3dAbEn6T0GWIpamkd1r6mnqT1zfYgB43XPuBS5hQmfZAjpeDeQcKInWrq6DH8HZImxDpaNmyRaY/cVn9pjMgm+cxros/PG9ExCSlEU2Jn6Lh67c1I+VfoKe65xiaMZkGc+ytuHvHIevcebsN0U4VXrrV8txa3RymIPCAINETqkxdjPoMTM7+Qi3gjn+mTiaAkgM/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by BL0PR11MB3073.namprd11.prod.outlook.com (2603:10b6:208:7c::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4930.15; Tue, 1 Feb 2022 14:12:13 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::5046:8550:928d:850e%7]) with mapi id 15.20.4930.022; Tue, 1 Feb 2022 14:12:13 +0000 Message-ID: <944f52a5-2778-d891-d891-de982f358ebb@intel.com> Date: Tue, 1 Feb 2022 14:12:07 +0000 Content-Language: en-US To: Akhil Goyal , , Radu Nicolau CC: , , , , , , , , References: <20220120162627.4155695-1-gakhil@marvell.com> <20220130175935.1947730-1-gakhil@marvell.com> <20220130175935.1947730-5-gakhil@marvell.com> From: Ferruh Yigit Subject: Re: [PATCH v3 4/4] security: add IPsec option for IP reassembly X-User: ferruhy In-Reply-To: <20220130175935.1947730-5-gakhil@marvell.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0170.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18a::13) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b2037aa3-75c7-43f1-2267-08d9e58cd7f0 X-MS-TrafficTypeDiagnostic: BL0PR11MB3073:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 89kIxkmVY4vy59iLW+BhPMeZOjnZdfN5GdaKoA13AjwQaFDA1FzBZwl8w72ngXqPoQYjCDK830NmYU8sBrSf40SUnXth1CpOk7IGw4uIOgOgdCCYEzZwwfxkJJVaCyUl78c3upgi2V5Q+FFxBopH3CP2WwJBqO9M3ZYs6qnH+oSTPkpRy1nPRm/wcFdCziNP+8DU2mTKaPxB+v0QawhYlXU/b9N/xdEb/gME9zhaU+MoG1FgkVHmhQSYyP+4FxO+2uXua+y0xUpXw6+IXtJaYVd9++4ZQ3uyRRc02JYjp2dJKv4mV/2YqSkwxD2ZXZHoZ+XM4+y6xik/GYrOFvx6JzH1Eh6r0pj757TADFGm21N0uQqgeGtri9e4axK0/FRHd868W12Kr3s1D1/hx8U66O52+JQAUWxgeskwZtIQXihkyTr+dX9K3HBp2WVO/ru9yeTCOtdtb9Nli4m9eDqTEz7eCESzqnJq9HSU9CgsJZ0J0S1uWtBBk3VoHtNrlOgWCEQCsLiPVIerBGfMniEpkVneEJp7xt20cx23oPtC+ZVNZ7hnsEb4v2fTC7emTwAIFRJpmEcI/5xKA4eo6QxH/mzjf1T78z5qhTYa3FeleTIYrvePRUVbCDf1u668fPjjAioX08lFrtYIUzX9Hea6NPw0fc2U/6/f0ufuDyQ2J/u4me3Yx2/dYrgJ0QkwXVInTIIdKt9KJBsUHLJGM7H/wQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(66946007)(31686004)(110136005)(6486002)(31696002)(44832011)(2906002)(82960400001)(5660300002)(15650500001)(6636002)(316002)(36756003)(6512007)(86362001)(38100700002)(8676002)(8936002)(4326008)(186003)(2616005)(6506007)(6666004)(26005)(66476007)(83380400001)(508600001)(53546011)(55236004)(66556008)(45980500001)(20210929001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cWVNOEFJczgzbHcvWU1GVnAwY0FnWjVPa1l0QVRUaEZ6QUdNSG9rQ2c0ZjBt?= =?utf-8?B?by9xWUhSYkdLc1pOckxJZC9vNnpNM3NIdXVqVlBhQjZiT3JSbGpJT2pCSGta?= =?utf-8?B?eWpLTXhUS1JpQVgveVRVVElRc0dYaEhqVk1rL3JFbmxOZFM3K29aS0FNem8y?= =?utf-8?B?OU15RTVYUTUzVm94cGV2WFlMVVRPZUtXVFQzSTg2S1c1cUVBRExxZjkxOVhr?= =?utf-8?B?TXV4bXJuWXlFSzVQRzJqcUROcjJWQnZFUmYwMnpkY2xleWJhTGxKOUNHUUl2?= =?utf-8?B?c1p3Rmt6QTcrc1g1SHdTVkxRc0psRTJseS93dWQvVE1YbTdCaG4zeUN3Z3Nm?= =?utf-8?B?azlNLzdQKzVWSzVxMWtnOVVIZTcxcUdOWG5CRkhET2tWQUhObkcwUXVJaEh6?= =?utf-8?B?dFFWUnZ4ZjdPeklsZzRkZFFCWTV1NXRIdTBIOVlBMUkyYkJmMFExcVp1OGt2?= =?utf-8?B?cGROVWRBdkdwK1VXSWZicGVrc0M2aUEzWVhOaW1heGlNZTMva0F1VXZSblM4?= =?utf-8?B?TFEyOHNFbmtmdHp5M0pGMFJNaUJOMHgyTDRFTHlzMmVEV0piYXBIQlRXeklN?= =?utf-8?B?S3dWMUYxUmErRG4zQ21DNk5QeEg4M3V2Wmt3cGk1V2VUeUZJckVUL08ycTBX?= =?utf-8?B?ZW1MTjQ5b0lqckRvQUtTeHdJaC9KTTVOZjdjZmdYVWJxNTdUVGFYWGJuQ09N?= =?utf-8?B?Z3E0ZDVWRG5lVmJjWHVBTVVOd01YT1YxQzI5bDRRSWsyRjZZY1pENDY5cCtz?= =?utf-8?B?dzRteUpxN0tlMzludTU5SEpadG9OQWJVSmZ4UUpzZE8zd05xTE5wQmtIeERF?= =?utf-8?B?WWd4clFrcmd3ZWNKL3YwZGdpU2lNc21VV1pDU2lXd2YzWHhZV2NiTU91UmdH?= =?utf-8?B?QjNmTWxVdk8xYXNGSUFUdnIzRTR0ZTBMd3RMRHMrOStMSk1RMFVxdlhMVE1I?= =?utf-8?B?cUYwdkNDakk3TzBwWmtLVm95M09pQWFyNnpxaWY0VHlBQVF0QzFiSUJaNWRy?= =?utf-8?B?K1p5VjVqTmpjMVN5MmFFUGZLalRXVHEzUGdxLzh5Q1JvK1JHN3lQMXUzN0Ev?= =?utf-8?B?dW1hangzZStxSTdVdUN2eUxOWitTZkVVSU5qYllLWVQ2OGJvbUJ1ajErWlk1?= =?utf-8?B?c2xxc21FV2NQMEZlYkRGdm9aR0V0TzZDankyMEFyREhlb2xwNk1tcG5odEV4?= =?utf-8?B?OE8vWTRJYUNBMTkwRmlGdGNxQ2YvajcrUHI5bi93aFN3TStIZmJuWVk2YTQ1?= =?utf-8?B?S0llRmswOUE0SjZxZnlrOGlGVzZhNHJRMEtncm8veFdrZlczRUFUUzB6RVVo?= =?utf-8?B?Wkw3bEgrbzUyNUVGSHBmeEVyYXM0NC84UG1GYTNIZ2I0KzkxV1NyTTVaemNG?= =?utf-8?B?TURFRk10N0N3b3RoK2ZEdGxDRnlMd2dqcjNvM1g3cjhSQ1FiUm9jUG42NkpM?= =?utf-8?B?OVAwVlVmQXF5SVBYbEk0a3VKK0hvZ1FEUHR3RVFST0kzRFpyMStEZHFQejFT?= =?utf-8?B?V2lvQW9ORFZZbTlkQmJ4eUtPeURPVFdaT1l4MFhSSng5T0wvbGRLR1lOODFU?= =?utf-8?B?NlF1VjBVQkdsM3ZVL3JxdW41L3p4cEFWbkg0Mlp4Sk15a0R1TFM3OXIzL1BK?= =?utf-8?B?ajk2akRyUHZ6U2tBSWx4aHFMb3lSL2doSnRNdWJ2YTYyYXFjNjFCclVQa3Jh?= =?utf-8?B?b3lLOU11UE0xMGVQekNuKzUyRk5GQTFqYkNDZCtGYktQV1c5UDZTRmM1ZlAw?= =?utf-8?B?VFFJZEJzRXdMRTBiSGtMSExRNmJmS0p1R1J3ZkpLNTZENFRud3ErUkhFTG5Q?= =?utf-8?B?Q0VxenFRbmZYU28rRVI5S3JjbUdWYkEveXE3QmcvR01nT1lFa3U5dTJycGFV?= =?utf-8?B?dmh1b2RUVytZb2JRYTBkTWphbWRoWVh2c0h4cmo5WEFFcXYxTUx3cEVGRzFx?= =?utf-8?B?cDVhNDVIUlE1bGVqNnpWNlZjOTk1RCtNcnd6V3lMYXdYYXRhaERReUQ3T0JY?= =?utf-8?B?LzhObld5VElnUHViVlhrWitIR2o4TVR3VitLeDJQblppekVRRHBxWFZtY3FG?= =?utf-8?B?dWdkN2pQRzl2dEhOd2pCdk5WVXlGOXZUM0ZpQVg0NzArZDdKZEZZYS9EeFpZ?= =?utf-8?B?V2ZmZWlrSTFpODkvM2p4VGsxeEczWnRzV0RJQVRLOVBMcUErTnJxUUlvb0FI?= =?utf-8?Q?TaxVd1q+kamHuik4Zz6DFp0=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: b2037aa3-75c7-43f1-2267-08d9e58cd7f0 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Feb 2022 14:12:13.2844 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: He5OIllUlphqelehyo9HAMPN20XHTNUeTU8rHL0bU6b+rHFO4s38R3N2/a9FqJRAM4bziXEhgq95zvOadg3Z5w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR11MB3073 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 1/30/2022 5:59 PM, Akhil Goyal wrote: > A new option is added in IPsec to enable and attempt reassembly > of inbound packets. > > Signed-off-by: Akhil Goyal > --- > devtools/libabigail.abignore | 14 ++++++++++++++ > lib/security/rte_security.h | 12 +++++++++++- +Radu for review > 2 files changed, 25 insertions(+), 1 deletion(-) > > diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore > index 90f449c43a..c6e304282f 100644 > --- a/devtools/libabigail.abignore > +++ b/devtools/libabigail.abignore > @@ -16,3 +16,17 @@ > [suppress_type] > name = rte_eth_dev_info > has_data_member_inserted_between = {offset_of(reserved_64s), end} > + > +; Ignore fields inserted in place of reserved_opts of rte_security_ipsec_sa_options > +[suppress_type] > + name = rte_ipsec_sa_prm > + name = rte_security_ipsec_sa_options > + has_data_member_inserted_between = {offset_of(reserved_opts), end} > + > +[suppress_type] > + name = rte_security_capability > + has_data_member_inserted_between = {offset_of(reserved_opts), (offset_of(reserved_opts) + 18)} > + > +[suppress_type] > + name = rte_security_session_conf > + has_data_member_inserted_between = {offset_of(reserved_opts), (offset_of(reserved_opts) + 18)} > diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h > index 1228b6c8b1..168b837a82 100644 > --- a/lib/security/rte_security.h > +++ b/lib/security/rte_security.h > @@ -264,6 +264,16 @@ struct rte_security_ipsec_sa_options { > */ > uint32_t l4_csum_enable : 1; > > + /** Enable reassembly on incoming packets. > + * > + * * 1: Enable driver to try reassembly of encrypted IP packets for > + * this SA, if supported by the driver. This feature will work > + * only if rx_offload RTE_ETH_RX_OFFLOAD_IP_REASSEMBLY is set in > + * inline Ethernet device. > + * * 0: Disable reassembly of packets (default). > + */ > + uint32_t reass_en : 1; > + > /** Reserved bit fields for future extension > * > * User should ensure reserved_opts is cleared as it may change in > @@ -271,7 +281,7 @@ struct rte_security_ipsec_sa_options { > * > * Note: Reduce number of bits in reserved_opts for every new option. > */ > - uint32_t reserved_opts : 18; > + uint32_t reserved_opts : 17; > }; > > /** IPSec security association direction */