From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 53DF5A0093;
	Thu, 13 Oct 2022 17:13:00 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 45F2942FDB;
	Thu, 13 Oct 2022 17:13:00 +0200 (CEST)
Received: from smail.rz.tu-ilmenau.de (smail.rz.tu-ilmenau.de [141.24.186.67])
 by mails.dpdk.org (Postfix) with ESMTP id D88EE42F7F
 for <dev@dpdk.org>; Thu, 13 Oct 2022 17:12:58 +0200 (CEST)
Received: from [10.183.254.100] (unknown [80.88.23.165])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by smail.rz.tu-ilmenau.de (Postfix) with ESMTPSA id 8A88C580098;
 Thu, 13 Oct 2022 17:12:58 +0200 (CEST)
Message-ID: <9458923c-6de8-5553-99a6-4193156b7869@tu-ilmenau.de>
Date: Thu, 13 Oct 2022 17:12:58 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.3.1
Subject: Re: [PATCH 2/2] build: export dpdk_includes for subproject usage.
Content-Language: en-US
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, Thorben Roemer <thorben.roemer@secunet.com>
References: <20221012144704.77973-1-markus.theil@tu-ilmenau.de>
 <20221012144704.77973-2-markus.theil@tu-ilmenau.de>
 <Y0bbfLNkxnwWUm19@bricha3-MOBL.ger.corp.intel.com>
From: Markus Theil <markus.theil@tu-ilmenau.de>
In-Reply-To: <Y0bbfLNkxnwWUm19@bricha3-MOBL.ger.corp.intel.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 10/12/22 17:21, Bruce Richardson wrote:
> On Wed, Oct 12, 2022 at 04:47:04PM +0200, Markus Theil wrote:
>> From: Thorben Roemer <thorben.roemer@secunet.com>
>>
>> In order to perform things like LTO more easily in
>> our DPDK applications, we use DPDK as a meson subproject.
>> Also export includes in order to be usable in this context.
>>
>> Signed-off-by: Thorben Roemer <thorben.roemer@secunet.com>
>> ---
>>   drivers/meson.build | 1 +
>>   lib/meson.build     | 1 +
>>   meson.build         | 1 +
>>   3 files changed, 3 insertions(+)
>>
>> diff --git a/drivers/meson.build b/drivers/meson.build
>> index 216971f4e2..d19b47df12 100644
>> --- a/drivers/meson.build
>> +++ b/drivers/meson.build
>> @@ -95,6 +95,7 @@ foreach subpath:subdirs
>>           objs = []
>>           cflags = default_cflags
>>           includes = [include_directories(drv_path)]
>> +        dpdk_includes += [include_directories(drv_path)]
> I am not sure that by default we should include all the driver directories.
> At most, we should only include those drivers which have header files to be
> made public. I think initially though we should only export library paths.
I tried to only include libraries. At least for our DPDK-based 
application, the bonding and i40e includes are needed. I therefore tried 
to include all drivers exporting symbols to the dpdk_includes list in 
the following revision.
> /Bruce
>