From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A3AF2A0547;
	Tue, 19 Oct 2021 20:07:51 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2DD8040142;
	Tue, 19 Oct 2021 20:07:51 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 8ED1D4003E
 for <dev@dpdk.org>; Tue, 19 Oct 2021 20:07:49 +0200 (CEST)
Received: from [192.168.1.192] (unknown [188.242.181.57])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id E7EC97F5B3;
 Tue, 19 Oct 2021 21:07:48 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru E7EC97F5B3
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1634666869;
 bh=4bR/pu3DafncPkDj/AbW+SmQRyiFVSTvlpT1rGEBLHI=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=GVGwvhcVWbWHuatMxyXxzDIJB4/5w1L376IAAs5C6+lfvX/wfU6antRBVJr/y1MUX
 M5JH47xR81jv9LgKxmZOFCc570F3ODmRrC2gbFX7mbdJgCqkHYyvv9GetLkcMQpINd
 G+8gM66qS72z3qTD1bFFUSQhf86jjoGxwexvgCeU=
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>
References: <20211014083704.2542493-1-andrew.rybchenko@oktetlabs.ru>
 <6fede0ad-5858-9423-3e86-1170269d01b4@intel.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Message-ID: <945d03fb-251b-eb75-f815-950754652b7b@oktetlabs.ru>
Date: Tue, 19 Oct 2021 21:07:48 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <6fede0ad-5858-9423-3e86-1170269d01b4@intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 0/5] ethdev: cosmetic fixes for just moved
 structures
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/19/21 2:55 PM, Ferruh Yigit wrote:
> On 10/14/2021 9:36 AM, Andrew Rybchenko wrote:
>> Sicne rte_eth_dev and rte_eth_dev_data structures are just moved
>> right now is a good chance to make a cleanup.
>>
>> No strong opinion, but I think it would be useful for the future.
>>
>> Make be at least some fixes from below could be accepted.
>>
>> Andrew Rybchenko (5):
>>    ethdev: avoid documentation in next lines
>>    ethdev: fix Rx/Tx spelling in just moved structures
>>    ethdev: remove reserved fields from internal structures
>>    ethdev: make device and data structures readable
>>    ethdev: remove full stop after short comments and references
>>
> 
> Overall +1 to these changes, I think this release is the opportunity
> to have changes like this.
> 
> But as far as I can see only new moved code updated in 'ethdev_driver.h',
> why not update whole 'ethdev_driver.h'?

Simply don't want to complicate search by git blame because of cosmetic
changes. No strong opinion, but decided to go this way for now.