From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 72FCA7CA9 for ; Mon, 10 Jul 2017 09:32:29 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 04BE0207AF; Mon, 10 Jul 2017 03:32:29 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 10 Jul 2017 03:32:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=qWm2Rq6B/5zbt8m 575fSCV1fQUYbkThv2jB9BKWGbA4=; b=aec494JDVwNNaY5X5yqTf5QKix0jXxM NFe1ll73MOZfixydldCJkB4af/PUFxLoiq8CnawpFRneAWE9w8o1S3c5gFZRgdxP 6VWjxPhpVs4ghzhcH1An/29qgt3pWRIkp/NEkbiffo8G6B9Q5ExhLwh3j+pnYlH8 +eoVbXBMxfnU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=qWm2Rq6B/5zbt8m575fSCV1fQUYbkThv2jB9BKWGbA4=; b=REVFHPg8 G15cdXUSpGsdykmEARaXWl48jlfhWcw3+Vtg2HEMj799jERVnwHsJCVNcUrltyWO 6CpV3VylLrF743TtI69+17u2f+WeZIllHtUEJ4RN5a4p09fl+8xJsdVAQ0LCatug YmpqxLPasWJJFdP5yAwMwxQntaRjjD07Fh+t2RaKIZIGhThcfwpsHvN5JHO/6HJw /7AMEcbkVl9NboSufagbQ237MvjhjJKDLtuCIVA2kECMgjBPxfZ9W0Pd7RJk2kHq KxFLHKc9rc61s6mtU2TKNQrw2Ssdx7k7uWNgxQjt3xZcsdFGCDRJBWTVOMVXx38/ x9Ov7ps8a3iw5Q== X-ME-Sender: X-Sasl-enc: VBRKNG2V4aTLzuRLHGEbuUfZSHm3WY+j1dMUtw7AmWGI 1499671948 Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id B221E7E2C1; Mon, 10 Jul 2017 03:32:28 -0400 (EDT) From: Thomas Monjalon To: Jianbo Liu , Jerin Jacob Cc: dev@dpdk.org, Jan Viktorin Date: Mon, 10 Jul 2017 09:32:27 +0200 Message-ID: <9464025.1hzSdOLmaj@xps> In-Reply-To: <1577823.H7hr8NYHfM@xps> References: <20170707162654.4638-1-jerin.jacob@caviumnetworks.com> <1577823.H7hr8NYHfM@xps> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal/armv7: emulate vaddvq u16 variant X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Jul 2017 07:32:29 -0000 10/07/2017 09:28, Thomas Monjalon: > 10/07/2017 05:51, Jianbo Liu: > > On 9 July 2017 at 01:08, Thomas Monjalon wrote: > > > 07/07/2017 18:26, Jerin Jacob: > > >> vaddvq_u16() is not available for armv7. > > >> Emulate the vaddvq_u16() using armv7 NEON intrinsics. > > > > > > After implementing this function, another missing function appears: > > > > > > lib/librte_sched/rte_sched.c:1747:7: error: > > > implicit declaration of function =E2=80=98vminvq_u32=E2=80=99 > >=20 > > But sched_vector is disabled in defconfig_arm-armv7a-linuxapp-gcc: > > CONFIG_RTE_SCHED_VECTOR=3Dn >=20 > Yes, I really need to fix test-build.sh which is enabling SCHED_VECTOR. >=20 > So with this patch, the error remains: > examples/l3fwd/l3fwd_neon.h:113:6: error: > implicit declaration of function =E2=80=98vaddvq_u16=E2=80=99 > v =3D vaddvq_u16(dp1); > ^~~~~~~~~~ >=20 > We need to include rte_vect.h. =46orget it, I mixed up my branches :/ So the patch is OK, compilation is fixed.