From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 83A4FA48A for ; Fri, 12 Jan 2018 18:18:44 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BCBE620FD6; Fri, 12 Jan 2018 12:18:43 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Fri, 12 Jan 2018 12:18:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=hrDHuFZaJdRwniT1CfXa9EPfl/ ASL5FhYKH41LRh9lU=; b=JHKe1qd/Qxgg7VNat53LfyNClyNaYqFu8lxAGOMwSm d0+TRJkO2eUmRkUdtfP5gJaz775cAsFsBNlr2OTj2ss2U1WtGUGDIajdAI3xHCkU Q3M8RDxMvr0/4uXz2W/7BEdzfkba2LSk1R3OiINb0WY6EGW7DTIOCZxZw2pDbca6 g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=hrDHuF ZaJdRwniT1CfXa9EPfl/ASL5FhYKH41LRh9lU=; b=LusNRPQdkyoNN0YYV1UaiY oCan0+8CbvRvUqd/MxWhnUyZ6yQk94lYS/y+ah3DXlD3/Hex6NzDUerNn6wqIXee v7qeVgk5hgI4cUAVQVwJK+laXFEbV4Vap3lrr5BepmMy2bpaVmMQEhoVaTmU5eeK DFlsFbPhPheRlLOx1BWUr4ZoyFab1RSjuzKyawedb8dBeTVWXK3/BhHrWazzzC+H E+5Q4QQVe3TUpB2LDckDr94vQxjglS36VTgmZ7h/eDaeDbgiUueHnV61C3JpeGX6 ubxvke1IcTPs7nnV9ukCZKS8AvyQx6KcFjiFUAczei1ok8wJ3u0l7tp0pr6tGzBg == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4E61A7E16A; Fri, 12 Jan 2018 12:18:43 -0500 (EST) From: Thomas Monjalon To: Jia He Cc: dev@dpdk.org, Jerin Jacob , Jianbo Liu , Jan Viktorin , Olivier Matz , konstantin.ananyev@intel.com, hemant.agrawal@nxp.com, Jia He Date: Fri, 12 Jan 2018 18:18:14 +0100 Message-ID: <94743066.En7L3yhnmx@xps> In-Reply-To: <1512352212-7191-4-git-send-email-hejianet@gmail.com> References: <1511748024-7245-1-git-send-email-hejianet@gmail.com> <1512352212-7191-1-git-send-email-hejianet@gmail.com> <1512352212-7191-4-git-send-email-hejianet@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH V7 3/3] ring: introduce new header file to support C11 memory model X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Jan 2018 17:18:44 -0000 Hi, Please find few comments. Sorry for the late review. We need also to get the acknowledgement from Olivier. 04/12/2017 02:50, Jia He: > --- a/config/common_armv8a_linuxapp > +++ b/config/common_armv8a_linuxapp > @@ -49,3 +49,5 @@ CONFIG_RTE_LIBRTE_SFC_EFX_PMD=n > CONFIG_RTE_LIBRTE_AVP_PMD=n > > CONFIG_RTE_SCHED_VECTOR=n > + > +CONFIG_RTE_RING_USE_C11_MEM_MODEL=y This config option should be added in the common file (as disabled). > --- /dev/null > +++ b/lib/librte_ring/rte_ring_c11_mem.h > @@ -0,0 +1,186 @@ > +/*- > + * BSD LICENSE > + * > + * Copyright(c) 2017 hxt-semitech. All rights reserved. > + * > + * Redistribution and use in source and binary forms, with or without > + * modification, are permitted provided that the following conditions > + * are met: > + * > + * * Redistributions of source code must retain the above copyright > + * notice, this list of conditions and the following disclaimer. > + * * Redistributions in binary form must reproduce the above copyright > + * notice, this list of conditions and the following disclaimer in > + * the documentation and/or other materials provided with the > + * distribution. > + * * Neither the name of hxt-semitech nor the names of its > + * contributors may be used to endorse or promote products derived > + * from this software without specific prior written permission. > + * > + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS > + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT > + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR > + * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT > + * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, > + * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT > + * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, > + * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY > + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT > + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE > + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > + */ If you have to spin a v8, please use SPDX tag for the license.