From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B0AB4A0524; Thu, 30 Jan 2020 11:57:22 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 881E51BFF6; Thu, 30 Jan 2020 11:57:22 +0100 (CET) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 4A5361BFE6 for ; Thu, 30 Jan 2020 11:57:21 +0100 (CET) Received: by mail-wr1-f66.google.com with SMTP id w15so3490541wru.4 for ; Thu, 30 Jan 2020 02:57:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=4A/WLpZgqOFe4Vme6txiqP1WkOLdDPRdUaJj3IZoJzc=; b=tHKju994ku19m9lE4y8QpE108Segv0mJwol3KtsFJnvQyIo72KFZmuZnACprJd9h6r KP9TcG7HBc+EVzTfSjRWwQKHRmsxyXoo68uezVo+UdlKD3yjmB/vGd7RAtfOLZFJto0I mKpghVcVeN44l7bV+doMIlZ1Ka2D+2cXKIJqOf+GQ8EX3aWtJ30wQpKmbc8rMNfpNaQd KxV2sEDDZ8RhClOgiVq34JnuPE2aYzBjtH/e9SVgkbFWtj+PMKDB8g1nWZ91SniIdOZB RicW74ymDVhDUhDDs4BpPS/qBYBGC13cmvLFq77lXwMy0W3L+BFMHQJH0dtgoA4YO0kh X+Vg== X-Gm-Message-State: APjAAAWzCBUlCEyA1PJl1vzFLHbbdDWKoGIRANTHYrGUyaj3DilreDT1 mZQVKvn5mQ2sNqBOpT7Xq4NC+viWNzE= X-Google-Smtp-Source: APXvYqxxAe7hXTWU1q8XNAgWK2upA4FmV4wBLXo2B70Mrb+QAi6YQts7oSEFNMIxdzxlaKJJbWePXg== X-Received: by 2002:a5d:5704:: with SMTP id a4mr5143658wrv.198.1580381840944; Thu, 30 Jan 2020 02:57:20 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id z3sm6901183wrs.94.2020.01.30.02.57.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jan 2020 02:57:20 -0800 (PST) Message-ID: <94766d183789f0969586f137ea4958ee9f81a908.camel@debian.org> From: Luca Boccassi To: David Marchand , dev@dpdk.org Date: Thu, 30 Jan 2020 10:57:19 +0000 In-Reply-To: <20200129172621.28565-1-david.marchand@redhat.com> References: <20191220152058.10739-1-david.marchand@redhat.com> <20200129172621.28565-1-david.marchand@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 0/4] add ABI checks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 2020-01-29 at 18:26 +0100, David Marchand wrote: > Here is the current state of the ABI checks. >=20 > libabigail has some issues when mixing dump and so files compiled > with > clang [1], so for now, all checks are done on dumps only. > libabigail 1.0-rc3 in Xenial reported issues that disappear with the > version 1.2 in Bionic. >=20 > To avoid getting warnings on internal types like [2], the checks now > make > use of the public headers part of a dpdk installation (patch 2 and 3 > to > prepare for this). >=20 > Some internal rte_hash headers were installed by meson, so patch 1 > fixes > this. >=20 > The most important point, abidiff complains on the rc1 cryptodev > changes: > - Chacha20-Poly1305 AEAD support, > - ECPM and ECDSA support >=20 > A suppression rule has been put on the internal type > rte_cryptodev_ops. > But other changes are an ABI breakage afaiu. I put suppression rules > on > them so that we can run the checks, but some action must be taken for > 20.02 if my analysis is confirmed. >=20 > Special thanks to Dodji the libabigail maintainer for helping on this > topic. >=20 > 1:=20 > https://sourceware.org/bugzilla/show_bug.cgi?id=3D25409 >=20 > 2:=20 > http://inbox.dpdk.org/dev/CAJFAV8yFKoDZROX9Mkyp7pDMvXw3e7mHwxjfrcjD5ZoFB2= tZ8w@mail.gmail.com/ >=20 >=20 > --=20 > David Marchand >=20 > David Marchand (4): > hash: fix meson headers packaging > build: split build helper > build: test meson installation > add ABI checks >=20 > .ci/linux-build.sh | 29 ++++++++- > .travis.yml | 20 +++++- > MAINTAINERS | 2 + > devtools/check-abi.sh | 59 +++++++++++++++++ > devtools/dpdk.abignore | 20 ++++++ > devtools/gen-abi.sh | 26 ++++++++ > devtools/test-build.sh | 45 ++++++++++++- > devtools/test-meson-builds.sh | 98 ++++++++++++++++++++++----- > -- > devtools/test-null.sh | 1 + > doc/guides/contributing/patches.rst | 13 ++++ > lib/librte_hash/meson.build | 5 +- > 11 files changed, 286 insertions(+), 32 deletions(-) > create mode 100755 devtools/check-abi.sh > create mode 100644 devtools/dpdk.abignore > create mode 100755 devtools/gen-abi.sh >=20 Series-acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi