From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF0FFA0524; Tue, 13 Apr 2021 19:08:54 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F6331611D6; Tue, 13 Apr 2021 19:08:54 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id DF0301611D4 for ; Tue, 13 Apr 2021 19:08:52 +0200 (CEST) IronPort-SDR: 0UHSPE1UgGbuY4bEPGZ4ctf7F6d5NCGImazj44t+cAjmiRX4C5fKx3ogxnt6L20HjsFWv6gQvU aYiy4+IDGT+Q== X-IronPort-AV: E=McAfee;i="6200,9189,9953"; a="194573035" X-IronPort-AV: E=Sophos;i="5.82,219,1613462400"; d="scan'208";a="194573035" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2021 10:08:51 -0700 IronPort-SDR: QZvUqBNEbZC7IFha2+O4sjvQxLJ/BZR0lM0SLCJqGw14nMcU6hA2Me1keZ4d+bCqaba6nqCLuQ h9gXH0Y06ezg== X-IronPort-AV: E=Sophos;i="5.82,219,1613462400"; d="scan'208";a="424342041" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.204.251]) ([10.213.204.251]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Apr 2021 10:08:49 -0700 To: "Min Hu (Connor)" , dev@dpdk.org Cc: xiaoyun.li@intel.com, Andrew Rybchenko , Qi Zhang , Ajit Khaparde References: <1617877348-16394-1-git-send-email-humin29@huawei.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <94a40608-6d33-3d24-f6ab-86424a50eab1@intel.com> Date: Tue, 13 Apr 2021 18:08:45 +0100 MIME-Version: 1.0 In-Reply-To: <1617877348-16394-1-git-send-email-humin29@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] app/testpmd: fix bitmap of link speeds when force speed X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/8/2021 11:22 AM, Min Hu (Connor) wrote: > From: Huisong Li > > Currently, when the user sets force link speed through 'link_speeds', > bit(0) of 'link_speeds' is not set to 1(ETH_LINK_SPEED_FIXED), > which conflicts with the definition. > > Fixes: 88fbedcd5e5a ("app/testpmd: move speed and duplex parsing in a function") > Cc: stable@dpdk.org > > Signed-off-by: Huisong Li > Signed-off-by: Min Hu (Connor) > --- > app/test-pmd/cmdline.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index f44116b..8c36de2 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -1523,6 +1523,9 @@ parse_and_check_speed_duplex(char *speedstr, char *duplexstr, uint32_t *speed) > printf("Unknown speed parameter\n"); > return -1; > } > + > + if (*speed != ETH_LINK_SPEED_AUTONEG) > + *speed |= ETH_LINK_SPEED_FIXED; > } > > return 0; > Acked-by: Ferruh Yigit This has a history, same patch has been done in the past by Andrew [1], later reverted [2] (by me) since some PMDs failed and we were close to release. In recent discussion [3] already agreed to get the patch again before -rc1, and this time there will be time to fix failing PMDs. Thanks for making the patch. [1] Commit bdca79053b6a ("app/testpmd: set fixed flag for exact link speed") [2] Commit f53cc91f412a ("app/testpmd: revert fixed flag for exact link speed") [3] http://inbox.dpdk.org/dev/43d67012-7f6f-2de8-e5ee-50cbe025d3eb@intel.com/#t