From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0A421459C6;
	Wed, 18 Sep 2024 09:37:54 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 90EFC42E67;
	Wed, 18 Sep 2024 09:37:53 +0200 (CEST)
Received: from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])
 by mails.dpdk.org (Postfix) with ESMTP id 39C3A4028F
 for <dev@dpdk.org>; Wed, 18 Sep 2024 09:37:52 +0200 (CEST)
Received: from mail.maildlp.com (unknown [172.19.88.194])
 by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4X7r8c36XVzFqlj;
 Wed, 18 Sep 2024 15:37:36 +0800 (CST)
Received: from dggpeml500024.china.huawei.com (unknown [7.185.36.10])
 by mail.maildlp.com (Postfix) with ESMTPS id 29F841406BF;
 Wed, 18 Sep 2024 15:37:50 +0800 (CST)
Received: from [10.67.121.161] (10.67.121.161) by
 dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2507.39; Wed, 18 Sep 2024 15:37:49 +0800
Message-ID: <9522e9c9-f696-48d0-a080-bf5e6c54f9e6@huawei.com>
Date: Wed, 18 Sep 2024 15:37:49 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v23 11/15] log: add timestamp option
To: Stephen Hemminger <stephen@networkplumber.org>, <dev@dpdk.org>
CC: =?UTF-8?Q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>
References: <20200814173441.23086-1-stephen@networkplumber.org>
 <20240918045830.3798-1-stephen@networkplumber.org>
 <20240918045830.3798-12-stephen@networkplumber.org>
Content-Language: en-US
From: fengchengwen <fengchengwen@huawei.com>
In-Reply-To: <20240918045830.3798-12-stephen@networkplumber.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.67.121.161]
X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To
 dggpeml500024.china.huawei.com (7.185.36.10)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 2024/9/18 12:56, Stephen Hemminger wrote:
> When debugging driver or startup issues, it is useful to have
> a timestamp on each message printed. The messages in syslog
> already have a timestamp, but often syslog is not available
> during testing.
> 
> There are multiple timestamp formats similar to Linux dmesg.
> The default is time relative since startup (when first
> step of logging initialization is done by constructor).
> Other alternative formats are delta, ctime, reltime and iso formats.
> 
> Example:
> $ dpdk-testpmd --log-timestamp -- -i
> [     0.008610] EAL: Detected CPU lcores: 8
> [     0.008634] EAL: Detected NUMA nodes: 1
> [     0.008792] EAL: Detected static linkage of DPDK
> [     0.010620] EAL: Multi-process socket /var/run/dpdk/rte/mp_socket
> [     0.012618] EAL: Selected IOVA mode 'VA'
> [     0.016675] testpmd: No probed ethernet devices
> Interactive-mode selected
> 

...

> +
> +static enum {
> +	LOG_TIMESTAMP_NONE = 0,
> +	LOG_TIMESTAMP_TIME,	/* time since start */
> +	LOG_TIMESTAMP_DELTA,	/* time since last message */
> +	LOG_TIMESTAMP_RELTIME,  /* relative time since last message */
> +	LOG_TIMESTAMP_CTIME,	/* Unix standard time format */
> +	LOG_TIMESTAMP_ISO,	/* ISO8601 time format */

Some of the impl should consider multiple-thread safety.

And for multiple-process, how about the secondary-processes align the main-process.