From: Thomas Monjalon <thomas@monjalon.net>
To: Gregory Etelson <getelson@nvidia.com>
Cc: dev@dpdk.org, matan@nvidia.com, rasland@nvidia.com,
viacheslavo@nvidia.com, Xueming Li <xuemingl@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix find sibling devices
Date: Wed, 04 Aug 2021 11:29:32 +0200 [thread overview]
Message-ID: <9523149.26U8Scermt@thomas> (raw)
In-Reply-To: <20210803150658.303-1-getelson@nvidia.com>
03/08/2021 17:06, Gregory Etelson:
> The routine mlx5_eth_find_next() and related iterating macro
> MLX5_ETH_FOREACH_DEV is used to iterate through sibling devices (all
> representors share the same configuration and switching domain) on top
> of specified root device.
>
> The root device parameter was specified as NULL, and it caused
> the missing siblings in iteration during representor device probing,
> causing:
>
> 1. allocating the new domain_id for the device being probed.
> 2. discrepancy in representor configurations and potential overall
> driver malfunctions.
>
> Fixes: 56bb3c84e982 ("net/mlx5: reduce PCI dependency")
>
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Applied, thanks.
prev parent reply other threads:[~2021-08-04 9:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 15:06 Gregory Etelson
2021-08-04 9:29 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9523149.26U8Scermt@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=getelson@nvidia.com \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=viacheslavo@nvidia.com \
--cc=xuemingl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).