From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94A84A0C45; Wed, 4 Aug 2021 11:29:37 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58E524014F; Wed, 4 Aug 2021 11:29:37 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mails.dpdk.org (Postfix) with ESMTP id 264204003E for ; Wed, 4 Aug 2021 11:29:35 +0200 (CEST) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id B44245C00C4; Wed, 4 Aug 2021 05:29:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 04 Aug 2021 05:29:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= BRhESz/dZ/I/2zI0Fj5vo6ga6Y0PfMqIhl29Vi5+2DY=; b=qDX+mZv4T+Jv6v8S ygdnbqLfqD/xO18ifUq36+vVjnnq9DXyEyiUzjp/4kFOIjAbMAsElaV4ORS94/8K awfnN/e7sK3dGt9m0Ggl1xBEbMppzkD4yZWdA5xm4muDYqmXAxjzSBGSN1rB4sfM WbyG7F7S7p3sAw3paU1prra9yljQQjjNJcggk6CzP4WgmzcNuQLRdg7UkfWTtlqd SLrvXBrQ+72bwZsyt8HHpnCHz+rWNqTfR0MjZ0PQ6aZsec4TlhtZNqolIbnfKAy4 LUQyip8d2i3/6UI0Gf5aHHLBuoJjV87hQ94KI95rDWfXg8WFoHky4j/wf/lQPrhN 1Vij9g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=BRhESz/dZ/I/2zI0Fj5vo6ga6Y0PfMqIhl29Vi5+2 DY=; b=dZm5S9fMPt5D363rMvorY44y5M+CN5w37ZhVenWaeJoenJXgra0wZUq9B CrQaOFtuCI6SeSuI0lB7RBGVYBodQwAUEJGivE37HLJVLq05ToNSf/nIXD+DW6R0 +kuXGJXInlIJxZg7TP6LNB8JhTQSYCHdP3oX26OqSdUsx+pnYYrh5WYXkK5og4TC wOomhylzPMrJt+uuW4OOeTgqEow0s0uxx5PzSt2FhoODjuJE6wR5q17TItuqyAmU pFqxcCcxraptWnlJmLipQ31EOBbvtJWXz4bm9oPAb9axbzP4lrdJbWw3YRjobZOV WJReiVDiOU4a9PXpnyeHs3/GJAjHg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrieeiucetufdoteggodetrfdotffvucfrrh hofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh ephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgrshcuofho nhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuggftrfgrth htvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeuieeivdff geehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepth hhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 4 Aug 2021 05:29:33 -0400 (EDT) From: Thomas Monjalon To: Gregory Etelson Cc: dev@dpdk.org, matan@nvidia.com, rasland@nvidia.com, viacheslavo@nvidia.com, Xueming Li Date: Wed, 04 Aug 2021 11:29:32 +0200 Message-ID: <9523149.26U8Scermt@thomas> In-Reply-To: <20210803150658.303-1-getelson@nvidia.com> References: <20210803150658.303-1-getelson@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] net/mlx5: fix find sibling devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 03/08/2021 17:06, Gregory Etelson: > The routine mlx5_eth_find_next() and related iterating macro > MLX5_ETH_FOREACH_DEV is used to iterate through sibling devices (all > representors share the same configuration and switching domain) on top > of specified root device. > > The root device parameter was specified as NULL, and it caused > the missing siblings in iteration during representor device probing, > causing: > > 1. allocating the new domain_id for the device being probed. > 2. discrepancy in representor configurations and potential overall > driver malfunctions. > > Fixes: 56bb3c84e982 ("net/mlx5: reduce PCI dependency") > > Signed-off-by: Gregory Etelson > Acked-by: Viacheslav Ovsiienko Applied, thanks.