From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7DDB2A034F; Mon, 30 Aug 2021 11:43:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 606FF4115A; Mon, 30 Aug 2021 11:43:20 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id C8B3341155 for ; Mon, 30 Aug 2021 11:43:18 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10091"; a="216397057" X-IronPort-AV: E=Sophos;i="5.84,363,1620716400"; d="scan'208";a="216397057" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2021 02:43:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,363,1620716400"; d="scan'208";a="518690564" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga004.fm.intel.com with ESMTP; 30 Aug 2021 02:43:17 -0700 Received: from fmsmsx608.amr.corp.intel.com (10.18.126.88) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Mon, 30 Aug 2021 02:43:17 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx608.amr.corp.intel.com (10.18.126.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Mon, 30 Aug 2021 02:43:17 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Mon, 30 Aug 2021 02:43:17 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FVes5FspjCHh2kiK5sOzZVB2XgjG4eTxUHf9kCDAgzgpUwYg5RTUU3RmbuPPFKiMAk3gEDb+5MtqXktcTK1jxCyEEqVb/H8y92gp/HXttopJQDR9N61ClVRC1veOXMoEH1WKt7LWFrzmsQDt2OaLBGQRqRfnHaw2mdE1h3Z7befPhW5lNkIT7GgWCZayF15fDks9VoKcr2s1DRkrd3tTDUOjID+/NOmhjhtCcurU4eLwC97lXFFPNbtz7OlXT6z96VG6HrMswwGqMz4LPwXYwWzSmIws+ZPWQ6fkn3E6MhQpjJgXHFImfp2dP8Q5n0YZkilMPUHK3zZEJlpnPDjEgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+9I2Bnbbv0xf2nErRAG/myHY9gOPs+fniMQZ0YTm7+4=; b=TH3nSoqfTA/ReWDLF1kcGsbuA8KUlj+wAb1ZiR7eUA6bnrjYt5+n1S8PEi8P6KvcusLMj4enRUr4QoDQNgaGcqb5YcLAqj49WmHQHSASM/PvtEc8i2KB2yFYp3miVlZSsm+gJv2d4C1SzWAoeMe2U3qEQR3/hgUHPLhjIvn4Q8EXZMQZEpZJG/R5tFc92uT1x+Jy7g/ExA9pYKLv9E4U0fi1x2pbjcW3RpBAa6bELWIBz8/U8KkKIMX88tB2ACbVvaIboQdAcBa9j7bScB6bX+IlNThri3nZVzKLINxE+JxL4OViQDoRNfbOlFgKfP6bmYMohgVvSLKjjOGVnUFEig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+9I2Bnbbv0xf2nErRAG/myHY9gOPs+fniMQZ0YTm7+4=; b=oUqtuJBXupt/cQcnsbaqkQWWZFs3s3NlM186TBQZrKhN3jXZSTmcXmnBwpbBjL51PkA6aPtCBtOGv2je7Zw9n0TF8cWUzf7frQvVjKq6o838OBMrh912EPe5s9dDE8WDRUMr3tDsA+RrCLsttg48SowKEZVYeZtTeu9O52ObLNQ= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4806.namprd11.prod.outlook.com (2603:10b6:510:31::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.24; Mon, 30 Aug 2021 09:43:14 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%4]) with mapi id 15.20.4457.024; Mon, 30 Aug 2021 09:43:14 +0000 To: "Xueming(Steven) Li" , Kevin Traynor , Ben Magistro , "dev@dpdk.org" , Beilei Xing , Luca Boccassi , Christian Ehrhardt CC: "ben.magistro@trinitycyber.com" , "stefan.baranoff@trinitycyber.com" , "Qi Zhang" References: <20210825194526.14987-1-koncept1@gmail.com> <94f93212-6432-710b-1135-638e359741da@intel.com> <11dd4ae3-0396-b237-7f2b-1484f07bb637@redhat.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <9527de1a-30ac-9bc9-ad11-14fbcd5207a1@intel.com> Date: Mon, 30 Aug 2021 10:43:07 +0100 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB6P193CA0009.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::19) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.206] (37.228.236.146) by DB6P193CA0009.EURP193.PROD.OUTLOOK.COM (2603:10a6:6:29::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.18 via Frontend Transport; Mon, 30 Aug 2021 09:43:12 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9f8c8579-4bd1-4ad6-c03c-08d96b9a963d X-MS-TrafficTypeDiagnostic: PH0PR11MB4806: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: +WPx0ZL3+sr2HifCF35QMUd0NNTkAHr/Hft/obS1EwQCTpZnOkwbASJAP1D9D1VaE8HpjCUZ+nAnTd9XRe2VIdYpDMZQYysI1N2N0RZuP+udBEXT2SAy70AONiVxr6ujux5YEhcKJPJBgNUF5f7xSXvaMtHDN3V6N32HHWDMBmMpSsgEIXG6it7g4Frbd/qTxiyt2pQHx9NySal1cCEt10VfGS3abtQzB/ECQKE4X/TXn4K7hkwr5wu1cJQhMexq9CLqsNZKnXiKAiXpwoLAJsIw/JGLS1+qZWKcLnUA6R4hf95a+wsMJFSpA9iUZLkI5kW+ua0gdFXT4/GlBwD6a0RAX7ZZ9nAhI7Hqt3o9HA40OYwzlYfBRyPVjpEMoVfvEHwCUH2ygJPwlCplFVVrVOt757jeujHDHodOJ+cCwmhqdXqxMIl8XAGfdCXKAJCW0ChVdTOhYGzt7nSZLZtQTmkctWbndmnk3JS7CV+f8NXT42OZ5XRNDMEtOHAq0oJc7nycvg3+UqlhtABUOPu+AC/3nINHJ841x/FcbjaYC9mHyzwaGtUBODhiRjPWneYWf4oK48cda20/sMud/tgmH3XuFP89svw+qfbOykNujs1di2evezlQNPltmoQ5YeXpRASKHo6iJliSwUMPNxC6j/2Tb3d2E4QKpuNrFgzUbHEc1Zys8Zs/1NaLc2I/BbYm+sxtlgbXcBRHoF6PaAtUg6Q0j/j5igjtvJn0VNONHLtxFpO1KbICqqinp8vRyx5nfSM/Bs237SgkiqOpX648cMem3ZrbXTNJNHR6ZiF6GJg= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(2616005)(31686004)(53546011)(107886003)(316002)(956004)(38100700002)(26005)(44832011)(8936002)(16576012)(186003)(508600001)(6486002)(966005)(8676002)(31696002)(4326008)(83380400001)(66556008)(66476007)(66946007)(6666004)(54906003)(86362001)(5660300002)(36756003)(110136005)(2906002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WTlsd0VNZm5kNFhQOXh1WEQ5Y0ZXWElWdVFoNGEza2l4dFh4dDZqZDVJTlJM?= =?utf-8?B?SmN3WmNBV1ZlK0dRUk02Slh2dGZwOHQxZk0yc1VqNEc0T3FteVE4VDRCUzdt?= =?utf-8?B?N3NEdWtKR2c3aHFXNE05OHJEcldNaVpiQmF5UTd4YXRNRnNUUVgzYmhCV0Rm?= =?utf-8?B?UjZQRkZ0TCsvV3JPanhEOWs4WTZucG1XLzRmV2hnWkU1RTJHampzdGdBZEJD?= =?utf-8?B?ckRhbmhmbnJXMTJrNEY1TENLZzhZeEJUSzB0SWpCYmdYOWhEbTVEYi90TTVs?= =?utf-8?B?dzZsQ1o0OWVUM3dES0FBUnlkS0pMNE5NcDJheExtL0tWQ0lIa01ScXZFZm0v?= =?utf-8?B?dGY3ZThTYXdZKzA3Z3N3am9BQUtNZEk0aktoeVlWYStEQW15TDBidm0ybnQw?= =?utf-8?B?WHlja0dYUFBWc1Y3STRoalkrR3V5YkRNVFEyL2g4Z0NDdnBWeFNIMTZoZk83?= =?utf-8?B?UVRlWXdWektFM2dyOTYvU1Q2NThueDlhMkhKaGt3d1Y0c2JRNGlpZWlCUml5?= =?utf-8?B?dzFYdmIvVjNSa2plNC9JREh2cDlBT3pVWktJMmhXektsOXdGb0lIeDREL2J2?= =?utf-8?B?ZGpYeWlOZDViUTRwNkpZTmtFUHFTd0NUK2FUYkNnMTFmbmxWT01XMVh0dDNk?= =?utf-8?B?ajI0T0pGanZ6WE1lUVhZMkFLMEJuTldmRVBMNWhGZW9oT1VsRi90YW9UYjBr?= =?utf-8?B?YUlsUW1FcWUzOHV3cEJVMXhaS3FDWUM4QUNKTXhnck1QQmtnNk5JZDVZTytI?= =?utf-8?B?cUt3b3I2bUcxQmk3aUZBUk5CVElIMGpxSzdYdHBpR1p6TjIySWhOS2gyTEVz?= =?utf-8?B?U3BnczI3UVQ4M0xkaTE1aWw3UG9BZFQyU3g1ZlVOQTlxQVllek1Db0tKeDB6?= =?utf-8?B?NE5BejlWODdGNEYveTJKdkY4bENuNWtXY2N2akZ2algvaFhUOE5ZODdsS1FY?= =?utf-8?B?b3R6bWVpL0VvSENZZjRvZjlYTlNRSlIyWmRwWHlUcXNMeUpkNGZNa1pZVkd2?= =?utf-8?B?RTlic1ZGVkRlSk9KTXgrRXhnMXlTZ0h3N3daY0dGaFVVZ1lESi9sQWJDYlhj?= =?utf-8?B?U0FYbWNDSm92elNIQkZZMzBZanJPTDVvVklSRDBXbUpmRjJkU1d4QnRjUE5z?= =?utf-8?B?dWhQSmxuQXc4WmdqM2Y4OFNJbG1zN2F1MnF5R1YxSThiZC8yWWw5eGd0Ui9i?= =?utf-8?B?UjNlR2VWdXV3NnVwU1F6NEZobCtINE91VWsvTk0wUGZ3OC96a2poeWx2RGM0?= =?utf-8?B?ZFAvS2F1dkNxSVRtUkVmUGQvVXA3OXlKdlg1SzdtSVE3S21lUXdBU1lUaDUx?= =?utf-8?B?ekhPeFlxbmd2TVFUZmxRWUx0czNTRmJObnZJVktJaVAxSmRpL3BFbUFPRmJQ?= =?utf-8?B?YWxwSk9DclhjQTZkbVA5SEU1bzM1STFJVlphdTFKS1pMODdFODZjWnJYcG5j?= =?utf-8?B?cjAwK2JFMjMzb0xEa0xiWEQxeXErYTVRZmdCOWVvOU8vTzNGWXQ5RXhtR210?= =?utf-8?B?UU9xeXRleEoveEQxS0RxallnVmVWMWZ3YWZXMEtQY3d0L05naGY0dlp4cDRp?= =?utf-8?B?N0VBQzJMMmV0NytVMkNWNmd5YW1WVlllYUxVWDVQZFV4NmJiektIaEx0U2ZQ?= =?utf-8?B?RDlJa2lJY0VsK0lRQ2wyWjEzMDhqVkhMc0xPNFM2NUtzVDBQSjY2NzNTcFIx?= =?utf-8?B?Ukk4NGZ2My8vYllwQmJxMkEyU1dJa1VjMmdXTUlyalJub2tkbFNiTE5pbThT?= =?utf-8?Q?Ie+LIJot9E2dOUjLrdggNYHW9VzMHeYTnOL5Xzn?= X-MS-Exchange-CrossTenant-Network-Message-Id: 9f8c8579-4bd1-4ad6-c03c-08d96b9a963d X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Aug 2021 09:43:14.0934 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: aCN/2j7N8r4uq6AYKEhFC9zgftkSVbxHkVvX1lDAtYXiolZ5Vy70lebvQ6rn2B3z4ml42HF3KNmhpkvGntN7VA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4806 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] driver: i40evf device initialization X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/27/2021 7:28 AM, Xueming(Steven) Li wrote: > > >> -----Original Message----- >> From: Kevin Traynor >> Sent: Thursday, August 26, 2021 6:46 PM >> To: Ferruh Yigit ; Ben Magistro ; dev@dpdk.org; Beilei Xing ; >> Luca Boccassi ; Christian Ehrhardt ; Xueming(Steven) Li >> >> Cc: ben.magistro@trinitycyber.com; stefan.baranoff@trinitycyber.com; Qi Zhang >> Subject: Re: [dpdk-dev] [PATCH] driver: i40evf device initialization >> >> + Christian and Xueming >> >> On 26/08/2021 11:25, Ferruh Yigit wrote: >>> On 8/25/2021 8:45 PM, Ben Magistro wrote: >>>> The i40evf driver is not initializing the eth_dev attribute which can >>>> result in a nullptr dereference. Changes were modeled after the >>>> iavf_dev_init() per suggestion from the mailing list[1]. >>>> >>>> [1] https://mails.dpdk.org/archives/dev/2021-August/217251.html >>>> >>>> Signed-off-by: Ben Magistro >>> >>> i40evf will be removed in this release. But I guess it helps for >>> stable releases to first merge the fixes and later removed it, not sure. >>> >>> @Luca, @Kevin, do you prefer this patch directly to stable repos, or >>> through the main repo? >> >> I'll leave to Luca/Xueming and Christian to say if they have a preference, but I'd guess either way is fine from stable view once it has >> fixes/stable tags or LTS patch prefix (it doesn't have any of these at present). > > Yes, any option will make it being noticed by LTS maintainer: > 1. patches accepted by main with "fix" in subject > 2. patches accepted by main with "cc: stable@dpdk.org" in commit message > 3. patches backported to LTS, sent to stable maillist with LTS prefix, for example "[20.11]" > Thanks Xueming, But is there a preferences for this case? The i40evf will be removed from main repo, is it better 1- first apply the fix and remove the component from main (I assume fix still will be bacported to LTS in this case) or 2- remove the i40evf from main (without fix), apply the fix directly to the LTS. Thanks, ferruh >> >>> i40evf won't be tested in the main anyway, since it would be removed >>> before -rc1 testing, so it looks like there won't be any difference from testing point of view. >>> >>> >>>> --- >>>> drivers/net/i40e/i40e_ethdev_vf.c | 8 ++++++-- >>>> 1 file changed, 6 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c >>>> b/drivers/net/i40e/i40e_ethdev_vf.c >>>> index 0cfe13b7b2..ccdce9a16a 100644 >>>> --- a/drivers/net/i40e/i40e_ethdev_vf.c >>>> +++ b/drivers/net/i40e/i40e_ethdev_vf.c >>>> @@ -1564,8 +1564,9 @@ i40evf_dev_alarm_handler(void *param) static >>>> int i40evf_dev_init(struct rte_eth_dev *eth_dev) { >>>> - struct i40e_hw *hw >>>> - = I40E_DEV_PRIVATE_TO_HW(eth_dev->data->dev_private); >>>> + struct i40e_adapter *adapter = >>>> + I40E_DEV_PRIVATE_TO_ADAPTER(eth_dev->data->dev_private); >>>> + struct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(adapter); >>>> struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(eth_dev); >>>> >>>> PMD_INIT_FUNC_TRACE(); >>>> @@ -1596,11 +1597,14 @@ i40evf_dev_init(struct rte_eth_dev *eth_dev) >>>> hw->device_id = pci_dev->id.device_id; >>>> hw->subsystem_vendor_id = pci_dev->id.subsystem_vendor_id; >>>> hw->subsystem_device_id = pci_dev->id.subsystem_device_id; >>>> + hw->bus.bus_id = pci_dev->addr.bus; >>>> hw->bus.device = pci_dev->addr.devid; >>>> hw->bus.func = pci_dev->addr.function; >>>> hw->hw_addr = (void *)pci_dev->mem_resource[0].addr; >>>> hw->adapter_stopped = 1; >>>> hw->adapter_closed = 0; >>>> + hw->back = I40E_DEV_PRIVATE_TO_ADAPTER(eth_dev->data->dev_private); >>>> + adapter->eth_dev = eth_dev; >>>> >>>> if(i40evf_init_vf(eth_dev) != 0) { >>>> PMD_INIT_LOG(ERR, "Init vf failed"); >>>> >>> >