From: Vipul Ashri <vipul.ashri@oracle.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, stable@dpdk.org, "Gaëtan Rivet" <grive@u256.net>
Subject: Re: [PATCH v2] net/failsafe: link_update request crashing at boot
Date: Tue, 15 Feb 2022 22:16:28 +0530 [thread overview]
Message-ID: <952c9880-9ad9-bfa6-e39a-271a06226640@oracle.com> (raw)
In-Reply-To: <f6eaebe9-9df2-7025-d6fb-36559e3e8838@oracle.com>
On 2/14/2022 10:24 PM, Stephen Hemminger wrote:
> On Mon, 14 Feb 2022 13:09:19 +0000
> Vipul Ashri <vipul.ashri@oracle.com> wrote:
>
>> PORT 0 supports 16 rx queues and 16 tx queues (driver_name = net_failsafe, driver_type = 16)
>>
>> PORT 0 is polling for link-change, interrupts disabled
>>
>> [DPDK] tap_flow_create(): Kernel refused TC filter rule creation (17): File exists
> Looks like secondary process support doesn't work with the flow rules logic.
> Maybe after that you are into error paths that may not recover correctly??
Thanks! Stephen for looking at my analysis,
yes some hotplug synchronization issue between eal_intr_thread and primary
thread, but we are able to recover with this patch.
Reason is this fail-safe flow is inside our custom added boot-time
polling to
update DPDK stats and calling ifindex ioctl to get interface data.
Ideally we
should not start polling so early. but moreover calling ifindex ioctl is
generic
functionality and should not break failsafe. We added this patch and
gracefully
prevented the so many multiple crashes.
Setup details :
Azure testbed with Accelerated Networking(SRIOV) enabled, failsafe using
tap +
mellanox driver.
Warm Regards
next prev parent reply other threads:[~2022-02-15 16:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 11:51 [dpdk-dev] [PATCH 1/1] " vipul.ashri
2021-10-21 21:42 ` [dpdk-dev] [PATCH v2] " vipul.ashri
2021-11-22 9:36 ` Ferruh Yigit
2021-11-22 10:23 ` Gaëtan Rivet
2022-02-15 16:24 ` Vipul Ashri
2022-02-15 16:46 ` Vipul Ashri [this message]
2023-10-17 16:43 ` Stephen Hemminger
2024-04-12 11:27 ` Ferruh Yigit
2023-07-07 9:35 ` Ferruh Yigit
2022-02-14 13:09 Vipul Ashri
2022-02-14 16:54 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=952c9880-9ad9-bfa6-e39a-271a06226640@oracle.com \
--to=vipul.ashri@oracle.com \
--cc=dev@dpdk.org \
--cc=grive@u256.net \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).