DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ivan Malov <ivan.malov@arknetworks.am>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: dev@dpdk.org, Aman Singh <aman.deep.singh@intel.com>,
	 Thomas Monjalon <thomas@monjalon.net>,
	 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	 Stephen Hemminger <stephen@networkplumber.org>,
	 Konstantin Ananyev <konstantin.ananyev@huawei.com>
Subject: Re: [PATCH v3 1/3] testpmd: Do not enable mbuf fast release TX offload by default
Date: Mon, 11 Aug 2025 12:41:54 +0400 (+04)	[thread overview]
Message-ID: <95547628-7d62-56c4-c775-4d554250b9a2@arknetworks.am> (raw)
In-Reply-To: <20250803194218.683318-1-mb@smartsharesystems.com>

[-- Attachment #1: Type: text/plain, Size: 1986 bytes --]

On Sun, 3 Aug 2025, Morten Brørup wrote:

> Enabling some offload by default may conflict with a manually configured
> offload.
> Specifically, the mbuf fast release TX offload, which conflicts with multi
> segment packet TX offload, was enabled by default.
> Therefore, mbuf fast release TX offload (the only TX offload which was
> enabled by default) is not enabled by default anymore.
>
> Signed-off-by: Morten Brørup <mb@smartsharesystems.com>

Acked-by: Ivan Malov <ivan.malov@arknetworks.am>

> ---
> app/test-pmd/testpmd.c | 11 +----------
> 1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index bb88555328..f00eae3992 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -490,9 +490,7 @@ lcoreid_t latencystats_lcore_id = -1;
>  */
> struct rte_eth_rxmode rx_mode;
>
> -struct rte_eth_txmode tx_mode = {
> -	.offloads = RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE,
> -};
> +struct rte_eth_txmode tx_mode;
>
> volatile int test_done = 1; /* stop packet forwarding when set to 1. */
>
> @@ -1592,10 +1590,6 @@ init_config_port_offloads(portid_t pid, uint32_t socket_id)
> 	if (ret != 0)
> 		rte_exit(EXIT_FAILURE, "rte_eth_dev_info_get() failed\n");
>
> -	if (!(port->dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE))
> -		port->dev_conf.txmode.offloads &=
> -			~RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE;
> -
> 	/* Apply Rx offloads configuration */
> 	for (i = 0; i < port->dev_info.max_rx_queues; i++)
> 		port->rxq[i].conf.offloads = port->dev_conf.rxmode.offloads;
> @@ -2857,9 +2851,6 @@ update_bonding_port_dev_conf(portid_t bond_pid)
> 		return;
> 	}
>
> -	if (port->dev_info.tx_offload_capa & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE)
> -		port->dev_conf.txmode.offloads |=
> -				RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE;
> 	/* Apply Tx offloads configuration */
> 	for (i = 0; i < port->dev_info.max_tx_queues; i++)
> 		port->txq[i].conf.offloads = port->dev_conf.txmode.offloads;
> -- 
> 2.43.0
>

  parent reply	other threads:[~2025-08-11  8:42 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-31  9:07 [PATCH] ethdev: Reject conflicting TX offloads configuration Morten Brørup
2025-07-31  9:24 ` Bruce Richardson
2025-07-31 10:07   ` Andrew Rybchenko
2025-07-31  9:27 ` Ivan Malov
2025-07-31  9:34   ` Morten Brørup
2025-07-31 11:32 ` Konstantin Ananyev
2025-07-31 12:56 ` [PATCH v2 1/3] testpmd: Do not enable mbuf fast release TX offload by default Morten Brørup
2025-07-31 12:56   ` [PATCH v2 2/3] ethdev: Improve descriptions of RX and TX offloads Morten Brørup
2025-07-31 12:56   ` [PATCH v2 3/3] ethdev: Reject conflicting TX offloads configuration Morten Brørup
2025-08-01  1:09     ` zhoumin
2025-08-02 20:53 ` [PATCH] " Stephen Hemminger
2025-08-02 21:33   ` Ivan Malov
2025-08-03 10:51     ` Morten Brørup
2025-08-03 15:56       ` Stephen Hemminger
2025-08-03 19:42 ` [PATCH v3 1/3] testpmd: Do not enable mbuf fast release TX offload by default Morten Brørup
2025-08-03 19:42   ` [PATCH v3 2/3] ethdev: Improve descriptions of RX and TX offloads Morten Brørup
2025-08-03 19:42   ` [PATCH v3 3/3] ethdev: Reject conflicting TX offloads configuration Morten Brørup
2025-08-05  2:10     ` fengchengwen
2025-08-05 13:11       ` Morten Brørup
2025-08-05  0:58   ` [PATCH v3 1/3] testpmd: Do not enable mbuf fast release TX offload by default fengchengwen
2025-08-05  5:48     ` Morten Brørup
2025-08-05  7:08       ` Ivan Malov
2025-08-05 15:48       ` Stephen Hemminger
2025-08-11  8:17   ` Morten Brørup
2025-08-11  8:41   ` Ivan Malov [this message]
2025-08-11  9:26     ` Andrew Rybchenko
2025-08-11  9:03   ` Konstantin Ananyev
2025-08-11 11:47   ` fengchengwen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=95547628-7d62-56c4-c775-4d554250b9a2@arknetworks.am \
    --to=ivan.malov@arknetworks.am \
    --cc=aman.deep.singh@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@huawei.com \
    --cc=mb@smartsharesystems.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).