From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FA80A00C2; Wed, 22 Apr 2020 11:16:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0B9BE1D170; Wed, 22 Apr 2020 11:16:19 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 8FE841D16D for ; Wed, 22 Apr 2020 11:16:17 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id CDC455C007B; Wed, 22 Apr 2020 05:16:16 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Wed, 22 Apr 2020 05:16:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= GQV1D4ONMjiPRD2gwVrJ2eVjuuVJeXozzt0at28Gbls=; b=f6Mu6uNOrF/alyh+ Y+ISxiS1b/rSzswoN0BKwWqVIepxrhjjBLhBpj9AtwMtL6tCaNjha1/sMhTKEFnB pfJblEVnWJT43qiJnwBWKIGkc9WLn4rRFV9crklIpbksg92OY41fvLAdMHG0eKr9 HKym7JVUaLry0Lm5ewI88OEbBh/GaRyxW2tE8o68wvZR9Vnaw7JKSAneswRuPbSX xwynAbgWtRPWg1rD98/y0aAnd8XThRJVvyC9wmMZ5SY516GdAYUWuGnvzEPRJi9r pBtH0OHXGlmAVVNTJL0i1Y0/iGNgbLZPmBylSXB1CfA8xUKn6Pgg9pi6Lm5y7rnS 0IotNA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=GQV1D4ONMjiPRD2gwVrJ2eVjuuVJeXozzt0at28Gb ls=; b=zYSqvaoi/6J5M49z+RCn77Rf/qTGmz/rHZTiOxjdxYSH6q9GxTMbEhUhD rYzZmAXxz/r7Y/BqoLRkyeeBMlXZcH4e2pp/FTcMZ1E/LlS0c+Gm1NUQWkoiTmd4 VaOhFBFFB268LWf8C1atwWp18jMLNfRQMzXwV3K048T2Pyp+wLxsDdeZddM+YGXG 1QZFE7SM4yTDeq+y3PtOaA3FhLlFqrBBgIcslAWLaz4XSc3JYzdcKNklwpGpMBYe yCHy5T+svXP+az/5BaHzdKb54j+7VtPrQ6UtGQMyqclRFYb8ChTd9+7YTqlsglto bQSSsbDMcsoaG9/LhaEkl7Sz+jHQA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrgeejgdduudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A95953280065; Wed, 22 Apr 2020 05:16:15 -0400 (EDT) From: Thomas Monjalon To: "akhil.goyal@nxp.com" , "De Lara Guarch, Pablo" Cc: dev@dpdk.org, "Doherty, Declan" , "Zhang, Roy Fan" Date: Wed, 22 Apr 2020 11:16:14 +0200 Message-ID: <9564647.0AQdONaE2F@thomas> In-Reply-To: <3924051.KRxA6XjA2N@thomas> References: <1586859760-207446-1-git-send-email-pablo.de.lara.guarch@intel.com> <3924051.KRxA6XjA2N@thomas> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/2] test/crypto: do not check for IMB_VERSION_NUM X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/04/2020 19:48, Thomas Monjalon: > 14/04/2020 19:22, De Lara Guarch, Pablo: > > From: Thomas Monjalon > > > 14/04/2020 12:22, Pablo de Lara: > > > > Now that capabilities are checked to see if an algorithm is supported > > > > by a device, there is no need to check for a specific version of a > > > > library used in a PMD. > > > > > > Yes, and even no need to check the PMD at all. > > > All *_TEST_TARGET_PMD_* constants should be removed. > > > > > > > I am currently working on this. However, I would like to split this effort > > into multiple patchsets. A first one addressing the problem of needing to check for > > specific information from PMDs (such as IMB_VERSION_NUM), which should not > > have any effect on the number of test cases ran for each PMD, and another one which > > addresses your comment, and that will enable test cases for all PMDs. > > This last patchset will require testing from all PMD maintainers and it is a less urgent > > problem to resolve, so we can decide if we want to merge it in this release or wait > > for more time in 20.08. > > Thanks for your efforts Pablo. > If the basic is working, I am for removing *_TEST_TARGET_PMD_* in 20.05, > and allow PMD maintainers to validate the tests during -rc phases. Some patches using capabilities are merged in the crypto test. What else is remaining? I see rte_cryptodev_driver_id_get() is still used. I think rte_cryptodev_driver_id_get() should be deprecated.