From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
[66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 303CF1B42D
for <dev@dpdk.org>; Thu, 27 Sep 2018 13:36:09 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id C36D121FDE;
Thu, 27 Sep 2018 07:36:08 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
by compute1.internal (MEProxy); Thu, 27 Sep 2018 07:36:08 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:content-transfer-encoding:content-type:date:from:in-reply-to
:message-id:mime-version:references:subject:to:x-me-sender
:x-me-sender:x-sasl-enc; s=mesmtp; bh=b2az5hl8bf2IJg95wnjdRG146m
2fQpjqcwrHjDrqZ/U=; b=PJIa60/e3IbmPQKDx32/Hklf9MjDJYlW7rZpi7IFWL
U0RD/AcATuIAzL/wTZCrLHUkJYbbpUY93htJzo0miMqRqKtpHSl+vDabLJTSrK7q
sw0+Qk7H5mH6x5E1Lb0boZxl2FU6BFJov+gWMWpMFGvQF4roF68PoNWYjCt/ZhXE
w=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=b2az5h
l8bf2IJg95wnjdRG146m2fQpjqcwrHjDrqZ/U=; b=mpc5/YnDkzfUUJ5eEECXSo
qA/BHox+MqiWHtYU8M9OE6kmrNhNijBql2jlpsGDwK4dRne+9ieHPD+wl3U+iYIm
pdYhikwFTqqGooO4dek0ejo67FfoqTBg7iIyNLu7dpFL4AethrZKv/sDFxwLnEkP
tgbdVejw76FROvuAv+h6Dkr06blHRNMBJPLVs0XAvsu/s/LK2uBcPyarfGpsajF/
O87HfFZnzlILK3GI8ZbIDyK/jZQM0DDMUESrU8ffi7VNAAUmFA91Re/Q9XN8H22y
uajo+YHLU5UNTqmyLnDaf3ptPfJRd4Su/JpPiOkqJAsqezWr/g2bgts6eYDnvdnw
==
X-ME-Proxy: <xmx:qMCsW83F9shvFs0t6QhTPo8c_7QWpxaf2it7PSkX7frtgxveWY4PYA>
<xmx:qMCsW42OTbv-9yc9yOl5AjsG3f-lp9s3atXrJRbOPcVZDA0sS0svsw>
<xmx:qMCsWzI2-xDelOJoqS3kl0DnGKO-1BBKG5gP6USSURbs9nW8H6cb7Q>
<xmx:qMCsW2Ob9D25a99UsrVwRyEFko6hiHcJK1AZjI8tleyFHtTaw2UwpQ>
<xmx:qMCsWzh9Y9T2Ez-qGa5345wXl95iNdp7IL8R8N4zB2Ie-NZnIvk_9A>
<xmx:qMCsW_5qj8j_7pL2sSNac30x6YFQBcbrjth2LPKoxz3takP8lTIXZQ>
X-ME-Sender: <xms:qMCsWz9ey6gli_8nChFn-FdCeVMdqK381SDvcJeMZCgfTntzUtDpew>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
by mail.messagingengine.com (Postfix) with ESMTPA id CE441102D7;
Thu, 27 Sep 2018 07:36:07 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Raslan Darawsheh <rasland@mellanox.com>
Cc: dev@dpdk.org, shahafs@mellanox.com, orika@mellanox.com
Date: Thu, 27 Sep 2018 13:36:06 +0200
Message-ID: <9568922.17cOiG4SW6@xps>
In-Reply-To: <1538047613-27309-1-git-send-email-rasland@mellanox.com>
References: <1538047613-27309-1-git-send-email-rasland@mellanox.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] examples/client_server_mp: add sigint
handler to server
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Sep 2018 11:36:09 -0000
27/09/2018 13:26, Raslan Darawsheh:
> v2:
> - fix includes order
I'm afraid you will need a v3 to fix spacing :)
> --- a/examples/multi_process/client_server_mp/mp_server/main.c
> +++ b/examples/multi_process/client_server_mp/mp_server/main.c
> @@ -37,6 +37,7 @@
> #include "common.h"
> #include "args.h"
> #include "init.h"
> +#include<signal.h>
A space is missing here.
> +static void signal_handler(int signal)
> +{
> + uint16_t port_id;
> +
> + if (signal == SIGINT)
> + RTE_ETH_FOREACH_DEV(port_id) {
> + rte_eth_dev_stop(port_id);
> + rte_eth_dev_close(port_id);
> + }
> + exit(0);
> +}
> int
> main(int argc, char *argv[])
A blank line is missing between the functions.