From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com
 [209.85.212.173]) by dpdk.org (Postfix) with ESMTP id 8137A282
 for <dev@dpdk.org>; Wed, 10 Dec 2014 14:57:21 +0100 (CET)
Received: by mail-wi0-f173.google.com with SMTP id r20so11303929wiv.0
 for <dev@dpdk.org>; Wed, 10 Dec 2014 05:57:21 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=zxYOag1fpD39CFzcg6TtsGUkKGv9fF2Ik+qnkuEildo=;
 b=M2mdIp3UzhFVhtqGwOKGxYGXOzObHbjycO5XNH8KRsBejQUlCKQtk5/sgndU7HxFZg
 +1CpcQhiK0v0CO1R42pXYP6TAx6OHS157rrfRGIntie2EDOPc2KsDd6RVRVrhuGXtz6T
 Loi5hUWQQTyFK+3U5VWlfBmpCv3w5xZ1bZDar15B05ppHB0PN/w5rrr80GFUjlpq53Cm
 +umwI74wIF7tOR1qJOLAhkth2tP/o8nRIGMZro1t/1QtLt9hX7Qgd9zdxvjTxX2dGiVD
 MRkaqMJoLRCxEM3OyywNUQ/aHuiPB5s6llgXYPb6rYgI8nOJWiZRDqkfmbiYo5NhxpQv
 iz6g==
X-Gm-Message-State: ALoCoQl8O0cGSrNibpl1KNmuyer2QHVHzT4x61fLe7aXUTnsBcKjV6rqROdTXPS8IGCojoJ6+kzz
X-Received: by 10.180.76.201 with SMTP id m9mr6602548wiw.52.1418219840497;
 Wed, 10 Dec 2014 05:57:20 -0800 (PST)
Received: from xps13.localnet ([176.219.165.187])
 by mx.google.com with ESMTPSA id p5sm18047863wix.7.2014.12.10.05.57.19
 for <multiple recipients>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Wed, 10 Dec 2014 05:57:19 -0800 (PST)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Date: Wed, 10 Dec 2014 14:56:50 +0100
Message-ID: <9583163.sZTCmdctQf@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.3 (Linux/3.17.4-1-ARCH; KDE/4.14.3; x86_64; ; )
In-Reply-To: <1417787182-20712-1-git-send-email-bruce.richardson@intel.com>
References: <533710CFB86FA344BFBF2D6802E60286C9D147@SHSMSX101.ccr.corp.intel.com>
 <1417787182-20712-1-git-send-email-bruce.richardson@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2] ixgbe: fix multi-process support
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 10 Dec 2014 13:57:21 -0000

2014-12-05 13:46, Bruce Richardson:
> When using multiple processes, the TX function used in all processes
> should be the same, otherwise the secondary processes cannot transmit
> more than tx-ring-size - 1 packets.
> To achieve this, we extract out the code to select the ixgbe TX function
> to be used into a separate function inside the ixgbe driver, and call
> that from a secondary process when it is attaching to an
> already-configured NIC.
> 
> Testing with symmetric MP app shows that we are able to RX and TX from
> both primary and secondary processes once this patch is applied.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> ----
> V2 Changes:
> * Moved check for primary/secondary process into set_tx_function instead
>   of ixgbe_txq_vec_setup, which reduces scope of diff.
> * Added/cleaned up some code comments for this change

Anyone to review this patch?

Thanks
-- 
Thomas