From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9082DA034C; Tue, 11 Jan 2022 17:41:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4041D41143; Tue, 11 Jan 2022 17:41:17 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 24691410F1 for ; Tue, 11 Jan 2022 17:41:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1641919275; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k/nAHm+QMYutSkZ4wJrdBzJ6PxQwJ/j8ACzbVWvUW4k=; b=b7ba/QWf80iw6W4wM1a1aGf1HiYawHBlly5yA7l3wav9+8ttxAGWC1Q3CG3Pbtmigu9rV/ ad5lbyWjMkGntDZrNhoKHNYzUnNl2eVzgI/iez0mXg18ng9JPG/ONT90mquOnUe46lmG+B RultWKiZC7y8M1NwcU06aNvyYOC3RAE= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-194-W9ONeW4XNV6aTaQyB3nhqw-1; Tue, 11 Jan 2022 11:41:14 -0500 X-MC-Unique: W9ONeW4XNV6aTaQyB3nhqw-1 Received: by mail-wm1-f69.google.com with SMTP id v190-20020a1cacc7000000b0034657bb6a66so3442852wme.6 for ; Tue, 11 Jan 2022 08:41:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:cc:references:from:subject:in-reply-to :content-transfer-encoding; bh=k/nAHm+QMYutSkZ4wJrdBzJ6PxQwJ/j8ACzbVWvUW4k=; b=IpNjGEaUrvEv1uUXQ1UnCRrCC1WPkDtZwWCAmlcgxp6Vt/ST8YJNLg7DIwJrPaRsIJ 6v8DSkHXhPVDmkgTjqwrwQ8HUU2BP63inYcmh3kgIC6xSwZFx1+poq1vRH1ozqKNAaZ9 fFf0jvVfbuK0Pgs4gK7k7cqDtfKGCof1+HhNw3U9r9vwrBait1OvtK0/xFbq94+svHLq MbkC8sBNc6k/Wk10DaEst7gNsBCcLwpztglS7veIgWE7VYctiY6/CgJT2jQCC0ZiuJCz x3qyh2MhuxODLRTctVWeLtlaLt10wNRPlW3r8kS8dn65D5Kp9bvd3D7UurELDC2pLrpM 6/KQ== X-Gm-Message-State: AOAM532EJ6n1lFXLus8e0V1b6yMI7+BAKzxwp1gPpnyX8FS6g2z5Y0Qc rX38Uq+iCa+wpdrzWuwpbZOSdmAuQ7bAajv6TNwjdutdNgl/sBNcO85xLX3135EO69IA73gLapq SSko= X-Received: by 2002:a05:6000:545:: with SMTP id b5mr4436946wrf.452.1641919273057; Tue, 11 Jan 2022 08:41:13 -0800 (PST) X-Google-Smtp-Source: ABdhPJyQbfdFHczwlmPxnBxSgSpL3zC7Y7osLA1q1Hy79OfsxfDeLgjEQFe9wvWfAJ9qT+iJPOhoXg== X-Received: by 2002:a05:6000:545:: with SMTP id b5mr4436938wrf.452.1641919272886; Tue, 11 Jan 2022 08:41:12 -0800 (PST) Received: from [192.168.0.36] ([78.19.108.41]) by smtp.gmail.com with ESMTPSA id p9sm1859803wmb.32.2022.01.11.08.41.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jan 2022 08:41:12 -0800 (PST) Message-ID: <95895af2-ec38-1206-4ad5-504331771d8c@redhat.com> Date: Tue, 11 Jan 2022 16:41:11 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 To: Robert Sanford , dev@dpdk.org Cc: chas3@att.com, humin29@huawei.com, bruce.richardson@intel.com References: <1639592401-56845-2-git-send-email-rsanford@akamai.com> <1640116650-3475-1-git-send-email-rsanford@akamai.com> From: Kevin Traynor Subject: Re: [PATCH v2 0/8] net/bonding: fixes and LACP short timeout In-Reply-To: <1640116650-3475-1-git-send-email-rsanford@akamai.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 21/12/2021 19:57, Robert Sanford wrote: > This patchset makes the following changes to net/bonding: > - Clean up minor errors in spelling, whitespace, C++ wrappers, and > comments. > - Replace directly overwriting of slave port's rte_eth_conf by copying > it, but only updating it via rte_eth_dev_configure(). > - Make minor changes to allocation of mbuf pool and rx/tx rings. > - Add support for enabling LACP short timeout, i.e., link partner can > use fast periodic time interval between transmits. > - Include bond_8023ad and bond_alb in doxygen. > - Remove self from Timers maintainers. > - Add API stubs to net/ring PMD. > - Add LACP short timeout to tests. > > V2 changes: > - Additional typo and whitespace corrections. > - Minor changes to LACP private rings creation. > - Add net/ring API stubs patch. > - Insert extra "bond_handshake" to LACP short timeout autotest. > > Robert Sanford (8): > net/bonding: fix typos and whitespace > net/bonding: fix bonded dev configuring slave dev > net/bonding: change mbuf pool and ring creation > net/bonding: support enabling LACP short timeout > net/bonding: add bond_8023ad and bond_alb to doc > Remove self from Timers maintainers. > net/ring: add promiscuous and allmulticast API stubs > net/bonding: add LACP short timeout to tests > You might want to consider patches that are fixes for backport to stable branches. Patches 1,2,3,5 look to be the ones most suited. > MAINTAINERS | 1 - > app/test-pmd/cmdline.c | 81 +++++++++++++++++++++- > app/test/test_link_bonding_mode4.c | 98 ++++++++++++++++++++++----- > doc/api/doxy-api-index.md | 2 + > drivers/net/bonding/eth_bond_8023ad_private.h | 15 ++-- > drivers/net/bonding/rte_eth_bond_8023ad.c | 58 ++++++++++------ > drivers/net/bonding/rte_eth_bond_8023ad.h | 18 +++-- > drivers/net/bonding/rte_eth_bond_pmd.c | 43 ++++++------ > drivers/net/ring/rte_eth_ring.c | 28 ++++++++ > 9 files changed, 272 insertions(+), 72 deletions(-) >