From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 0184D100F; Tue, 29 Aug 2017 19:06:38 +0200 (CEST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Aug 2017 10:05:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,445,1498546800"; d="scan'208";a="123718612" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by orsmga004.jf.intel.com with ESMTP; 29 Aug 2017 10:05:54 -0700 To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= , Matan Azrad Cc: dev@dpdk.org, stable@dpdk.org References: <20170821132533.GW8124@bidouze.vm.6wind.com> <1503818594-52694-1-git-send-email-matan@mellanox.com> <20170828075222.GD8124@bidouze.vm.6wind.com> From: Ferruh Yigit Message-ID: <95ade482-3ce8-c451-e747-93c46928f34c@intel.com> Date: Tue, 29 Aug 2017 18:05:53 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170828075222.GD8124@bidouze.vm.6wind.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] net/failsafe: fix parameters parsing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2017 17:06:39 -0000 On 8/28/2017 8:52 AM, Gaëtan Rivet wrote: > Hi Matan, > > thanks > > On Sun, Aug 27, 2017 at 10:23:14AM +0300, Matan Azrad wrote: >> The corrupted code used wrongly snprintf return value as the >> number of characters actually copied, in spite of the meanning >> is the number of characters which would be generated for the >> given input. >> >> It caused to remain zerod bytes between the failsafe command line >> non sub device parameters indicates end of string. >> >> Hence, when rte_kvargs_parse tried to parse all parameters, it >> got end of string after the first one and the others weren't parsed. >> >> So, if the mac parameters was the first in command line it was >> taken while hotplug_poll was left default, and vice versa. >> >> The fix updates the buffer index by dedicated variable contains >> the copy size, by the way validates the comma separation. >> >> Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD") >> Cc: stable@dpdk.org >> >> Signed-off-by: Matan Azrad > Acked-by: Gaetan Rivet Applied to dpdk-next-net/master, thanks.